Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Oct 28, 2025

This was referenced Oct 28, 2025
@dorimedini-starkware dorimedini-starkware self-assigned this Oct 28, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review October 28, 2025 14:14
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_experimental_contract_flow branch from 295f603 to 68cc601 Compare November 9, 2025 15:35
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_new_account_flow branch from 54a7e82 to 71f6388 Compare November 9, 2025 15:35
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_experimental_contract_flow branch from 68cc601 to f96ae19 Compare November 12, 2025 13:37
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_new_account_flow branch from 71f6388 to 7ac865b Compare November 12, 2025 13:37
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_experimental_contract_flow branch from f96ae19 to 02c3bc0 Compare November 12, 2025 14:05
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_new_account_flow branch from 7ac865b to 580f4b8 Compare November 12, 2025 14:05
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_experimental_contract_flow branch from 02c3bc0 to 0fb7b91 Compare November 12, 2025 18:00
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_new_account_flow branch from 580f4b8 to e4d3975 Compare November 12, 2025 18:00
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_experimental_contract_flow branch from 0fb7b91 to aff638e Compare November 12, 2025 20:06
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_new_account_flow branch from e4d3975 to 5a84018 Compare November 12, 2025 20:07
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/starknet_os_flow_tests/src/tests.rs line 1611 at r2 (raw file):

    );

    // Verify that the funded account, the new account and the sequencer all have changed balances.

Suggestion:

// Verify that the funded account and the sequencer have both updated their balances.

@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_new_account_flow branch from 5a84018 to ac0b5d3 Compare November 13, 2025 09:37
@graphite-app graphite-app bot changed the base branch from 10-28-starknet_os_flow_tests_split_test_new_class_flow_experimental_contract_flow to graphite-base/9822 November 13, 2025 09:52
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_new_account_flow branch from ac0b5d3 to c43afc6 Compare November 13, 2025 10:13
@graphite-app graphite-app bot changed the base branch from graphite-base/9822 to main-v0.14.1-committer November 13, 2025 10:13
@graphite-app
Copy link

graphite-app bot commented Nov 13, 2025

Merge activity

  • Nov 13, 10:13 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main-v0.14.1-committer with commit dd0c535 Nov 13, 2025
22 of 32 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants