-
Notifications
You must be signed in to change notification settings - Fork 65
starknet_os_flow_tests: split test_new_class_flow exec-info txs #9820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starknet_os_flow_tests: split test_new_class_flow exec-info txs #9820
Conversation
f522dd2 to
54f6fac
Compare
6970e8d to
fc257ac
Compare
54f6fac to
abf460c
Compare
fc257ac to
ee849c4
Compare
abf460c to
2954fd9
Compare
ee849c4 to
31f0b3f
Compare
2954fd9 to
345db06
Compare
31f0b3f to
116fb19
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dorimedini-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)
116fb19 to
79536f1
Compare
meship-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meship-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/starknet_os_flow_tests/src/tests.rs line 1007 at r2 (raw file):
#[rstest] #[tokio::test] async fn test_new_class_execution_info(#[values(true, false)] use_kzg_da: bool) {
I am not sure why it does not pass with 5 blocks in a multi-block, but as it shouldn't be part of this test, this is non-blocking
Code quote:
async fn test_new_class_execution_info(#[values(true, false)] use_kzg_da: bool) {
meship-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/starknet_os_flow_tests/src/tests.rs line 1007 at r2 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
I am not sure why it does not pass with 5 blocks in a multi-block, but as it shouldn't be part of this test, this is non-blocking
Never mind it's just a block number issue, you can ignore this comment
meship-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
meship-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
e0106d8

No description provided.