-
Notifications
You must be signed in to change notification settings - Fork 65
starknet_os_flow_tests: migrate test_meta_tx #9553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starknet_os_flow_tests: migrate test_meta_tx #9553
Conversation
66d34a6 to
c7f57a8
Compare
c69203e to
32fdb11
Compare
c7f57a8 to
a73f1c4
Compare
32fdb11 to
1be2d4d
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dorimedini-starkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)
a73f1c4 to
2d01273
Compare
1be2d4d to
a7593fa
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dorimedini-starkware reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)
2d01273 to
831cefc
Compare
a7593fa to
0fc55c9
Compare
831cefc to
7ebfd03
Compare
0fc55c9 to
d5495c5
Compare
7ebfd03 to
5e97819
Compare
72ccb5e to
ca4309e
Compare
|
Artifacts upload workflows: |
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dorimedini-starkware reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)
ca4309e to
308dc8e
Compare
rotem-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rotem-starkware reviewed 1 of 1 files at r4.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @dorimedini-starkware, @meship-starkware, and @Yoni-Starkware)
crates/starknet_os_flow_tests/src/tests.rs line 2478 at r5 (raw file):
let tx0_hash = tx0.tx_hash(); let tx0_nonce = tx0.nonce(); assert!(tx0.nonce() != Nonce(Felt::ZERO));
suggestion
Suggestion:
assert!(tx0_nonce != Nonce(Felt::ZERO));308dc8e to
4bc24e8
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dorimedini-starkware reviewed 1 of 1 files at r7, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)

No description provided.