Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Oct 11, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-blockifier_test_utils_update_meta-tx_test_contract branch from 66d34a6 to c7f57a8 Compare November 26, 2025 06:21
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-starknet_os_flow_tests_migrate_test_meta_tx branch from c69203e to 32fdb11 Compare November 26, 2025 06:21
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-blockifier_test_utils_update_meta-tx_test_contract branch from c7f57a8 to a73f1c4 Compare December 2, 2025 10:58
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-starknet_os_flow_tests_migrate_test_meta_tx branch from 32fdb11 to 1be2d4d Compare December 2, 2025 10:59
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-blockifier_test_utils_update_meta-tx_test_contract branch from a73f1c4 to 2d01273 Compare December 2, 2025 11:57
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-starknet_os_flow_tests_migrate_test_meta_tx branch from 1be2d4d to a7593fa Compare December 2, 2025 11:58
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-blockifier_test_utils_update_meta-tx_test_contract branch from 2d01273 to 831cefc Compare December 2, 2025 16:22
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-starknet_os_flow_tests_migrate_test_meta_tx branch from a7593fa to 0fc55c9 Compare December 2, 2025 16:22
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-blockifier_test_utils_update_meta-tx_test_contract branch from 831cefc to 7ebfd03 Compare December 2, 2025 16:23
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-starknet_os_flow_tests_migrate_test_meta_tx branch from 0fc55c9 to d5495c5 Compare December 2, 2025 16:24
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-blockifier_test_utils_update_meta-tx_test_contract branch from 7ebfd03 to 5e97819 Compare December 2, 2025 19:23
@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-starknet_os_flow_tests_migrate_test_meta_tx branch 2 times, most recently from 72ccb5e to ca4309e Compare December 2, 2025 20:12
@dorimedini-starkware dorimedini-starkware changed the base branch from 10-11-blockifier_test_utils_update_meta-tx_test_contract to main-v0.14.1-committer December 2, 2025 20:12
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Artifacts upload workflows:

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)

Copy link
Contributor

@rotem-starkware rotem-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@rotem-starkware reviewed 1 of 1 files at r4.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @dorimedini-starkware, @meship-starkware, and @Yoni-Starkware)


crates/starknet_os_flow_tests/src/tests.rs line 2478 at r5 (raw file):

    let tx0_hash = tx0.tx_hash();
    let tx0_nonce = tx0.nonce();
    assert!(tx0.nonce() != Nonce(Felt::ZERO));

suggestion

Suggestion:

assert!(tx0_nonce != Nonce(Felt::ZERO));

@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-starknet_os_flow_tests_migrate_test_meta_tx branch from 308dc8e to 4bc24e8 Compare December 4, 2025 16:02
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Dec 5, 2025
Merged via the queue into main-v0.14.1-committer with commit e624493 Dec 5, 2025
17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants