starknet_os_flow_tests: migrate test_new_class_flow

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• starknet_os_flow_tests: migrate test_initial_sierra_gas #9539 : 2 dependent PRs (#9544 , #9546 )
• starknet_os_flow_tests: migrate test_block_info #9529
• blockifier_test_utils: add block_info_test_contract contracts #9528
• starknet_os_flow_tests: migrate test_deploy_syscall #9527
• starknet_os_flow_tests: migrate test_deprecated_tx_info #9525
• blockifier_test_utils: add tx_info_writer cairo0 contract #9524
• starknet_os_flow_tests: rename test #9823
• starknet_os_flow_tests: split test_new_class_flow new account flow #9822
• starknet_os_flow_tests: split test_new_class_flow experimental contract flow #9821
• starknet_os_flow_tests: split test_new_class_flow exec-info txs #9820
• starknet_os_flow_tests: use nonce as deployment salt #9819
• starknet_os_flow_tests: implement get_builtin_usage #9818
• starknet_os_flow_tests: implement update_expected_storage_updates_for_block_hash_contract #9817
• starknet_os_flow_tests: migrate test_new_class_flow #9518 👈 (View in Graphite)
• starknet_os_flow_tests: add update_expected_storage util #9805
• blockifier_test_utils: add experimental contract and it's libfuncs list #9517
• blockifier_test_utils: put tx hash in signature for exec info tests #9516
• blockifier: extract get_expected_execution_info to function #9515
• blockifier: update test contract for test_new_contract_flow #9514
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Benchmark movements: tree_computation_flow performance regressed! tree_computation_flow time: [14.255 ms 14.440 ms 14.678 ms] change: [+1.4730% +3.7079% +5.9993%] (p = 0.00 < 0.05) Performance has regressed. Found 12 outliers among 100 measurements (12.00%) 4 (4.00%) low mild 5 (5.00%) high mild 3 (3.00%) high severe full_committer_flow performance regressed! full_committer_flow time: [15.106 ms 15.227 ms 15.348 ms] change: [+3.9994% +5.2575% +6.4580%] (p = 0.00 < 0.05) Performance has regressed. Found 7 outliers among 100 measurements (7.00%) 5 (5.00%) low mild 2 (2.00%) high mild

[github-actions]

Artifacts upload workflows:

• Started at 2025-10-06T16:52:37Z
• Started at 2025-10-08T07:13:36Z
• Started at 2025-10-08T07:46:54Z
• Started at 2025-10-08T07:49:16Z
• Started at 2025-10-08T13:31:44Z
• Started at 2025-10-08T13:44:32Z
• Started at 2025-10-08T13:48:49Z
• Started at 2025-10-08T13:55:53Z
• Started at 2025-10-08T14:57:03Z
• Started at 2025-10-09T08:29:13Z
• Started at 2025-10-09T09:35:23Z
• Started at 2025-10-09T09:48:40Z
• Started at 2025-10-09T11:12:33Z
• Started at 2025-10-09T11:46:22Z
• Started at 2025-10-09T12:58:37Z
• Started at 2025-10-09T13:10:37Z
• Started at 2025-10-09T13:31:51Z
• Started at 2025-10-09T14:19:23Z
• Started at 2025-10-09T15:23:42Z
• Started at 2025-10-14T10:23:19Z
• Started at 2025-10-15T11:21:30Z
• Started at 2025-10-19T18:44:08Z
• Started at 2025-10-23T08:51:45Z
• Started at 2025-10-23T12:46:04Z
• Started at 2025-10-26T08:27:29Z
• Started at 2025-10-28T08:52:15Z
• Started at 2025-10-28T09:50:00Z
• Started at 2025-10-28T09:49:55Z
• Started at 2025-10-28T14:11:47Z
• Started at 2025-11-03T07:56:05Z
• Started at 2025-11-09T15:27:15Z
• Started at 2025-11-12T10:55:23Z
• Started at 2025-11-12T12:48:11Z
• Started at 2025-11-12T14:04:44Z

[Yoni-Starkware]

@Yoni-Starkware reviewed 3 of 4 files at r1, all commit messages.
Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @meship-starkware)

[dorimedini-starkware]

Reviewable status: 2 of 5 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @meship-starkware)

---

crates/starknet_os_flow_tests/src/tests.rs line 1039 at r2 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

This is the exact function we defined in test_os_logic. Consider sharing the code here
can be done in a separate PR

Done (in the new PR below this one)

[dorimedini-starkware]

Reviewable status: 2 of 5 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @meship-starkware)

---

a discussion (no related file):

Previously, meship-starkware (Meshi Peled) wrote…

Is there a reason the new_class test is one test? It is very long and hard to debug. I think that we can split it into two or three different tests. If we want to avoid adding another test, let's at least split its content into helper functions

Done, in PRs above this one (3 small refactors, 3 splits, one for test rename)

[meship-starkware]

@meship-starkware reviewed 1 of 3 files at r3, 1 of 1 files at r4, 3 of 3 files at r5, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @AvivYossef-starkware)

---

crates/starknet_os_flow_tests/src/tests.rs line 1318 at r5 (raw file):

        nonce: test_manager.next_nonce(*FUNDED_ACCOUNT_ADDRESS),
    };
    let account_declare_tx = declare_tx(declare_tx_args);

Why aren't we using Bootstrap declare here?

Code quote:

let account_declare_tx = declare_tx(declare_tx_args);

---

crates/starknet_os_flow_tests/src/tests.rs line 1357 at r5 (raw file):

        &[Felt::from(queried_block_number.0), old_block_hash.0],
    );
    test_manager.add_funded_account_invoke(invoke_tx_args! { calldata });

Do we check the message to L1? If not, should we test it here?

Code quote:

test_manager.add_funded_account_invoke(invoke_tx_args! { calldata });

---

crates/starknet_os_flow_tests/src/tests.rs line 1380 at r5 (raw file):

        test_library_call_key,
        test_library_call_value,
    );

Suggestion:

    update_expected_storage(
        &mut expected_storage_updates,
        //Library call write to the caller storage 
        main_contract_address,
        test_library_call_key,
        test_library_call_value,
    );

[dorimedini-starkware]

Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @meship-starkware)

---

crates/starknet_os_flow_tests/src/tests.rs line 1318 at r5 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Why aren't we using Bootstrap declare here?

done. I didn't see a point, but I don't see why not either

---

crates/starknet_os_flow_tests/src/tests.rs line 1357 at r5 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Do we check the message to L1? If not, should we test it here?

test_get_block_hash doesn't send an L1 message, this was an error in the original test (note that message_to_l1 is defined twice, once after test_send_message_to_l1 and once again after test_get_block_hash)

[meship-starkware]

@meship-starkware reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)