-
Notifications
You must be signed in to change notification settings - Fork 65
starknet_os_flow_tests: split test_new_class_flow experimental contract flow #9821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
meship-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/starknet_os_flow_tests/src/tests.rs line 1218 at r1 (raw file):
.assert_debug_eq(&poseidons); } }
There is no need to check the Poseidon usage in all three functions. Keeping it in this one is enough
Code quote:
let poseidons = test_output.get_builtin_usage(&BuiltinName::poseidon);
if use_kzg_da {
expect![[r#"
58
"#]]
.assert_debug_eq(&poseidons);
} else {
expect![[r#"
49
"#]]
.assert_debug_eq(&poseidons);
}
}6970e8d to
fc257ac
Compare
295f603 to
68cc601
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @meship-starkware)
crates/starknet_os_flow_tests/src/tests.rs line 1218 at r1 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
There is no need to check the Poseidon usage in all three functions. Keeping it in this one is enough
deleted other poseidon validations
fc257ac to
ee849c4
Compare
68cc601 to
f96ae19
Compare
ee849c4 to
31f0b3f
Compare
f96ae19 to
02c3bc0
Compare
31f0b3f to
116fb19
Compare
02c3bc0 to
0fb7b91
Compare
116fb19 to
79536f1
Compare
0fb7b91 to
aff638e
Compare
meship-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meship-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
aff638e to
ffb063a
Compare
Merge activity
|

No description provided.