Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Oct 28, 2025

This was referenced Oct 28, 2025
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/starknet_os_flow_tests/src/tests.rs line 1218 at r1 (raw file):

        .assert_debug_eq(&poseidons);
    }
}

There is no need to check the Poseidon usage in all three functions. Keeping it in this one is enough

Code quote:

    let poseidons = test_output.get_builtin_usage(&BuiltinName::poseidon);
    if use_kzg_da {
        expect![[r#"
            58
        "#]]
        .assert_debug_eq(&poseidons);
    } else {
        expect![[r#"
            49
        "#]]
        .assert_debug_eq(&poseidons);
    }
}

@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_exec-info_txs branch from 6970e8d to fc257ac Compare November 9, 2025 15:35
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_experimental_contract_flow branch from 295f603 to 68cc601 Compare November 9, 2025 15:35
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @meship-starkware)


crates/starknet_os_flow_tests/src/tests.rs line 1218 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

There is no need to check the Poseidon usage in all three functions. Keeping it in this one is enough

deleted other poseidon validations

@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_exec-info_txs branch from fc257ac to ee849c4 Compare November 12, 2025 12:48
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_experimental_contract_flow branch from 68cc601 to f96ae19 Compare November 12, 2025 13:37
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_exec-info_txs branch from ee849c4 to 31f0b3f Compare November 12, 2025 14:05
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_experimental_contract_flow branch from f96ae19 to 02c3bc0 Compare November 12, 2025 14:05
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_exec-info_txs branch from 31f0b3f to 116fb19 Compare November 12, 2025 18:00
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_experimental_contract_flow branch from 02c3bc0 to 0fb7b91 Compare November 12, 2025 18:00
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_exec-info_txs branch from 116fb19 to 79536f1 Compare November 12, 2025 20:06
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_experimental_contract_flow branch from 0fb7b91 to aff638e Compare November 12, 2025 20:06
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware changed the base branch from 10-28-starknet_os_flow_tests_split_test_new_class_flow_exec-info_txs to main-v0.14.1-committer November 13, 2025 09:52
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_flow_tests_split_test_new_class_flow_experimental_contract_flow branch from aff638e to ffb063a Compare November 13, 2025 09:52
@graphite-app
Copy link

graphite-app bot commented Nov 13, 2025

Merge activity

  • Nov 13, 9:53 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main-v0.14.1-committer with commit 9a33d1b Nov 13, 2025
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants