blockifier_test_utils: update meta-tx test contract #9552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 11, 2025
|
This change is |
This was referenced Oct 11, 2025
Collaborator
Author
This was referenced Oct 11, 2025
dorimedini-starkware
requested review from
AvivYossef-starkware,
Yoni-Starkware and
meship-starkware
dorimedini-starkware
force-pushed
the
10-11-starknet_os_flow_tests_migrate_test_direct_execute_call
branch
from
9492f14 to
7162c6f
Compare
dorimedini-starkware
force-pushed
the
10-11-blockifier_test_utils_update_meta-tx_test_contract
branch
from
a2b1fe5 to
aa71839
Compare
dorimedini-starkware
force-pushed
the
10-11-starknet_os_flow_tests_migrate_test_direct_execute_call
branch
from
7162c6f to
63f153b
Compare
dorimedini-starkware
force-pushed
the
10-11-blockifier_test_utils_update_meta-tx_test_contract
branch
from
aa71839 to
ad2ca4f
Compare
dorimedini-starkware
force-pushed
the
10-11-starknet_os_flow_tests_migrate_test_direct_execute_call
branch
from
63f153b to
1ab0396
Compare
dorimedini-starkware
force-pushed
the
10-11-blockifier_test_utils_update_meta-tx_test_contract
branch
from
ad2ca4f to
eb0e51c
Compare
Contributor
|
Previously, meship-starkware (Meshi Peled) wrote…
Looks like the contract is much longer, so I think it makes sense that the margin is larger |
meship-starkware
approved these changes
Nov 18, 2025
Collaborator
meship-starkware
left a comment
meship-starkware
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @Yoni-Starkware)
dorimedini-starkware
force-pushed
the
10-11-starknet_os_flow_tests_migrate_test_direct_execute_call
branch
from
1ab0396 to
4d86f40
Compare
dorimedini-starkware
force-pushed
the
10-11-blockifier_test_utils_update_meta-tx_test_contract
branch
from
eb0e51c to
66d34a6
Compare
dorimedini-starkware
force-pushed
the
10-11-starknet_os_flow_tests_migrate_test_direct_execute_call
branch
from
4d86f40 to
da87e12
Compare
dorimedini-starkware
force-pushed
the
10-11-blockifier_test_utils_update_meta-tx_test_contract
branch
from
66d34a6 to
c7f57a8
Compare
dorimedini-starkware
force-pushed
the
10-11-starknet_os_flow_tests_migrate_test_direct_execute_call
branch
from
da87e12 to
85b5a5d
Compare
dorimedini-starkware
force-pushed
the
10-11-blockifier_test_utils_update_meta-tx_test_contract
branch
from
c7f57a8 to
a73f1c4
Compare
Collaborator
Author
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
dorimedini-starkware
force-pushed
the
10-11-starknet_os_flow_tests_migrate_test_direct_execute_call
branch
from
85b5a5d to
b22ac4c
Compare
dorimedini-starkware
force-pushed
the
10-11-blockifier_test_utils_update_meta-tx_test_contract
branch
from
a73f1c4 to
2d01273
Compare
graphite-app
bot
changed the base branch from
10-11-starknet_os_flow_tests_migrate_test_direct_execute_call
to
graphite-base/9552
dorimedini-starkware
force-pushed
the
10-11-blockifier_test_utils_update_meta-tx_test_contract
branch
from
2d01273 to
831cefc
Compare
dorimedini-starkware
changed the base branch from
graphite-base/9552
to
main-v0.14.1-committer
Collaborator
Author
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed all commit messages.
Reviewable status:
dorimedini-starkware
force-pushed
the
10-11-blockifier_test_utils_update_meta-tx_test_contract
branch
from
831cefc to
7ebfd03
Compare
dorimedini-starkware
force-pushed
the
10-11-blockifier_test_utils_update_meta-tx_test_contract
branch
from
7ebfd03 to
5e97819
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.