Skip to content

blockifier: extract get_expected_execution_info to function #9515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dorimedini-starkware merged 1 commit into from
Nov 12, 2025
Merged

blockifier: extract get_expected_execution_info to function #9515

dorimedini-starkware merged 1 commit into from
Nov 12, 2025

Conversation

@dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Oct 6, 2025

No description provided.

@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Oct 6, 2025

This change is Reviewable

@dorimedini-starkware dorimedini-starkware mentioned this pull request Oct 6, 2025
Merged
@dorimedini-starkware Graphite App
Copy link
Collaborator Author

dorimedini-starkware commented Oct 6, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Oct 6, 2025
Merged
Merged
Merged
@github-actions
Copy link

github-actions bot commented Oct 6, 2025 •
edited
Loading

Artifacts upload workflows:

@dorimedini-starkware dorimedini-starkware self-assigned this Oct 6, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review October 6, 2025 17:26
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from 4a01137 to 0c893d7 Compare October 6, 2025 18:12
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_update_test_contract_for_test_new_contract_flow branch from 088c95f to 0990b31 Compare October 8, 2025 13:30
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from 0c893d7 to b1c1a13 Compare October 8, 2025 13:31
This was referenced Oct 8, 2025
Merged
Merged
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_update_test_contract_for_test_new_contract_flow branch from 0990b31 to a4a38ba Compare October 8, 2025 13:43
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from b1c1a13 to bc5242e Compare October 8, 2025 13:44
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_update_test_contract_for_test_new_contract_flow branch from a4a38ba to 81ebc5f Compare October 8, 2025 13:48
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from bc5242e to 3bc279e Compare October 8, 2025 13:48
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_update_test_contract_for_test_new_contract_flow branch from 81ebc5f to a8b81e7 Compare October 8, 2025 13:55
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from 3bc279e to 02d9fbe Compare October 8, 2025 13:55
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_update_test_contract_for_test_new_contract_flow branch from a8b81e7 to b99e538 Compare October 8, 2025 14:56
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from 02d9fbe to c1dbd61 Compare October 8, 2025 14:56
This was referenced Oct 8, 2025
Merged
Merged
Merged
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_update_test_contract_for_test_new_contract_flow branch from b99e538 to 5f2c34a Compare October 9, 2025 08:28
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from c1dbd61 to f29a8a4 Compare October 9, 2025 08:28
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_update_test_contract_for_test_new_contract_flow branch from 71d1a40 to 39a4c59 Compare October 23, 2025 11:12
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from 38e2dab to bce99b6 Compare October 23, 2025 11:12
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_update_test_contract_for_test_new_contract_flow branch from 39a4c59 to e28090b Compare October 23, 2025 12:44
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from bce99b6 to 98dac2a Compare October 23, 2025 12:44
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_update_test_contract_for_test_new_contract_flow branch from e28090b to da2556c Compare October 26, 2025 08:26
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from 98dac2a to 46ff0b0 Compare October 26, 2025 08:27
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_update_test_contract_for_test_new_contract_flow branch from da2556c to e219708 Compare October 28, 2025 08:51
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from 46ff0b0 to 532ee37 Compare October 28, 2025 08:51
@dorimedini-starkware dorimedini-starkware mentioned this pull request Oct 28, 2025
Merged
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from 532ee37 to 01b132f Compare October 28, 2025 14:11
@dorimedini-starkware dorimedini-starkware changed the base branch from 10-05-blockifier_update_test_contract_for_test_new_contract_flow to main-v0.14.1-committer October 28, 2025 14:11
This was referenced Oct 28, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from 01b132f to 77ba652 Compare November 3, 2025 07:55
meship-starkware
meship-starkware requested changes Nov 5, 2025
View reviewed changes
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @Yoni-Starkware)

crates/blockifier/src/transaction/test_utils.rs line 551 at r1 (raw file):

            }) => {
                vec![
                    Felt::THREE,

Can you add a short comment on the meaning of this element in the vector

Code quote:

                Felt::THREE,

meship-starkware
meship-starkware approved these changes Nov 5, 2025
View reviewed changes
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @dorimedini-starkware, and @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from 77ba652 to 81246a4 Compare November 9, 2025 15:26
meship-starkware
meship-starkware approved these changes Nov 12, 2025
View reviewed changes
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @Yoni-Starkware)

meship-starkware
meship-starkware approved these changes Nov 12, 2025
View reviewed changes
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Nov 12, 2025
Merged via the queue into main-v0.14.1-committer with commit 19be075 Nov 12, 2025
22 checks passed
rotem-starkware pushed a commit that referenced this pull request Nov 12, 2025
@dorimedini-starkware @rotem-starkware
blockifier: extract get_expected_execution_info to function (#9515)
d66c37d
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@meship-starkware meship-starkware meship-starkware approved these changes

@AvivYossef-starkware AvivYossef-starkware Awaiting requested review from AvivYossef-starkware

@Yoni-Starkware Yoni-Starkware Awaiting requested review from Yoni-Starkware

Assignees

@dorimedini-starkware dorimedini-starkware

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dorimedini-starkware @reviewable-StarkWare @meship-starkware