starknet_os_flow_tests: use nonce as deployment salt #9819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Collaborator
Author
This was referenced Oct 28, 2025
This was referenced Oct 28, 2025
meship-starkware
approved these changes
Nov 3, 2025
Collaborator
meship-starkware
left a comment
meship-starkware
left a comment
There was a problem hiding this comment.
@meship-starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
dorimedini-starkware
force-pushed
the
10-28-starknet_os_flow_tests_implement_get_builtin_usage
branch
from
0436e6d to
5b56976
Compare
dorimedini-starkware
force-pushed
the
10-28-starknet_os_flow_tests_use_nonce_as_deployment_salt
branch
from
f522dd2 to
54f6fac
Compare
dorimedini-starkware
force-pushed
the
10-28-starknet_os_flow_tests_implement_get_builtin_usage
branch
from
5b56976 to
9db65c7
Compare
dorimedini-starkware
force-pushed
the
10-28-starknet_os_flow_tests_use_nonce_as_deployment_salt
branch
from
54f6fac to
abf460c
Compare
meship-starkware
approved these changes
Nov 12, 2025
Collaborator
meship-starkware
left a comment
meship-starkware
left a comment
There was a problem hiding this comment.
@meship-starkware reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
dorimedini-starkware
force-pushed
the
10-28-starknet_os_flow_tests_implement_get_builtin_usage
branch
from
9db65c7 to
08aecad
Compare
dorimedini-starkware
force-pushed
the
10-28-starknet_os_flow_tests_use_nonce_as_deployment_salt
branch
from
abf460c to
2954fd9
Compare
dorimedini-starkware
force-pushed
the
10-28-starknet_os_flow_tests_implement_get_builtin_usage
branch
from
08aecad to
53d186c
Compare
dorimedini-starkware
force-pushed
the
10-28-starknet_os_flow_tests_use_nonce_as_deployment_salt
branch
from
2954fd9 to
345db06
Compare
Collaborator
Author
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:
dorimedini-starkware
changed the base branch from
10-28-starknet_os_flow_tests_implement_get_builtin_usage
to
main-v0.14.1-committer
dorimedini-starkware
force-pushed
the
10-28-starknet_os_flow_tests_use_nonce_as_deployment_salt
branch
from
345db06 to
ed89595
Compare
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.