Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Nov 17, 2025

Artifacts upload workflows:

Copy link
Collaborator Author

dorimedini-starkware commented Nov 17, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @Yoni-Starkware)


crates/starknet_os_flow_tests/src/tests.rs line 2947 at r1 (raw file):

            );
            // Migration is enabled, and V1-declare should be enabled only for the first block.
            block_ctx.versioned_constants.enable_casm_hash_migration = true;

This should also be false for the first block. We do not support migrating declared transactions, but we also don't want the first declaration to migrate, as we want to test the migration of the class after it was previously declared.

Suggestion:

 block_ctx.versioned_constants.enable_casm_hash_migration = *i > 0;

@dorimedini-starkware dorimedini-starkware force-pushed the 10-11-starknet_os_flow_tests_add_all_uncovered_regression_test branch from ded6eb6 to 2ab1b55 Compare November 20, 2025 10:49
@dorimedini-starkware dorimedini-starkware force-pushed the 11-17-starknet_os_flow_tests_migrate_test_compiled_class_hash_migration branch from ea95b46 to 057d535 Compare November 20, 2025 10:49
@dorimedini-starkware dorimedini-starkware changed the base branch from 10-11-starknet_os_flow_tests_add_all_uncovered_regression_test to 11-18-starknet_os_flow_tests_better_v1-v2_class_handling November 20, 2025 10:49
@dorimedini-starkware dorimedini-starkware marked this pull request as draft November 26, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants