-
Notifications
You must be signed in to change notification settings - Fork 65
starknet_os_flow_tests: migrate test_compiled_class_hash_migration #10210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Artifacts upload workflows: |
meship-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @Yoni-Starkware)
crates/starknet_os_flow_tests/src/tests.rs line 2947 at r1 (raw file):
); // Migration is enabled, and V1-declare should be enabled only for the first block. block_ctx.versioned_constants.enable_casm_hash_migration = true;
This should also be false for the first block. We do not support migrating declared transactions, but we also don't want the first declaration to migrate, as we want to test the migration of the class after it was previously declared.
Suggestion:
block_ctx.versioned_constants.enable_casm_hash_migration = *i > 0;ded6eb6 to
2ab1b55
Compare
ea95b46 to
057d535
Compare

No description provided.