-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_gateway: insert optional versioned constant overrides to batcher #10285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apollo_gateway: insert optional versioned constant overrides to batcher #10285
Conversation
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)
74b46eb to
21939ad
Compare
23c9984 to
e981a1d
Compare
21939ad to
c8e15be
Compare
TzahiTaub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TzahiTaub reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @itamar-starkware)
crates/apollo_batcher_config/src/config.rs line 41 at r2 (raw file):
proposer_idle_detection_delay_millis: Duration::from_millis(2000), // Preserve behavior by defaulting to Some(default overrides). versioned_constants_overrides: Some(VersionedConstantsOverrides::default()),
As in the GW, shiuld be None by default.
Code quote:
versioned_constants_overrides: Some(VersionedConstantsOverrides::default()),
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yoni-Starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @itamar-starkware and @TzahiTaub)
crates/apollo_batcher_config/src/config.rs line 41 at r2 (raw file):
I think that this should either be
None(and the default impl should be removed)
+1
c8e15be to
ca29fcc
Compare
e981a1d to
5ad1ea7
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShahakShama reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @itamar-starkware and @TzahiTaub)
TzahiTaub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TzahiTaub reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @itamar-starkware)
5ad1ea7 to
d8cb1a7
Compare
ca29fcc to
b0808ae
Compare
TzahiTaub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TzahiTaub reviewed 2 of 2 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @itamar-starkware)
TzahiTaub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TzahiTaub reviewed 2 of 2 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @itamar-starkware)
d8cb1a7 to
9059e91
Compare
b0808ae to
3f28fa2
Compare
itamar-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itamar-starkware reviewed 2 of 4 files at r5, 2 of 2 files at r6, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @itamar-starkware)

Make
versioned_constants_overridesoptional inBlockBuilderConfig.What changed?
versioned_constants_overridesfield inBlockBuilderConfigto beOption<VersionedConstantsOverrides>instead ofVersionedConstantsOverridesSome()dump()method to handle the case when the value isNoneVersionedConstants::get_versioned_constants()to pass the option directly instead of wrapping it inSome()Why make this change?
This change allows for more flexibility in configuration by making the versioned constants overrides optional. It maintains backward compatibility by preserving the default behavior while allowing users to explicitly opt out of providing overrides if desired.