Skip to content

Conversation

@itamar-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

itamar-starkware commented Nov 26, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@itamar-starkware itamar-starkware self-assigned this Nov 26, 2025
@itamar-starkware itamar-starkware changed the base branch from 11-19-apollo_node_config_make_top_level_version_constant_overrides_optional to graphite-base/10438 November 26, 2025 21:05
@itamar-starkware itamar-starkware force-pushed the 11-26-apollo_batcher_reorder_async_trait_and_automock_annotation branch from 1b19fb0 to 26d5c21 Compare November 26, 2025 21:05
@itamar-starkware itamar-starkware changed the base branch from graphite-base/10438 to main-v0.14.1 November 26, 2025 21:05
@itamar-starkware itamar-starkware marked this pull request as ready for review November 26, 2025 21:07
Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TzahiTaub reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @itamar-starkware)


crates/apollo_batcher/src/batcher_test.rs line 146 at r1 (raw file):

            let (non_working_pre_confirmed_tx_sender, _) = tokio::sync::mpsc::channel(1);
            let mut mock_writer = Box::new(MockPreconfirmedBlockWriterTrait::new());
            mock_writer.expect_run().returning(|| Ok(()));

Why was this changed?

Suggestion:

.return_once(||

@itamar-starkware
Copy link
Contributor Author

crates/apollo_batcher/src/batcher_test.rs line 146 at r1 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Why was this changed?

Not a good reason. return once is more accurate.
Fixed.

@itamar-starkware itamar-starkware force-pushed the 11-26-apollo_batcher_reorder_async_trait_and_automock_annotation branch from 26d5c21 to 5fe01e8 Compare November 26, 2025 21:48
Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@TzahiTaub reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @itamar-starkware)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants