-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_batcher: reorder async_trait and automock annotation #10438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main-v0.14.1
Are you sure you want to change the base?
apollo_batcher: reorder async_trait and automock annotation #10438
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c47330a to
4b542bd
Compare
1b19fb0 to
26d5c21
Compare
TzahiTaub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TzahiTaub reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @itamar-starkware)
crates/apollo_batcher/src/batcher_test.rs line 146 at r1 (raw file):
let (non_working_pre_confirmed_tx_sender, _) = tokio::sync::mpsc::channel(1); let mut mock_writer = Box::new(MockPreconfirmedBlockWriterTrait::new()); mock_writer.expect_run().returning(|| Ok(()));
Why was this changed?
Suggestion:
.return_once(|||
Previously, TzahiTaub (Tzahi) wrote…
Not a good reason. return once is more accurate. |
26d5c21 to
5fe01e8
Compare
TzahiTaub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TzahiTaub reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @itamar-starkware)

No description provided.