Skip to content

Commit ca29fcc

Browse files
apollo_gateway: insert optional versioned constant overrides to batcher
1 parent 5ad1ea7 commit ca29fcc

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

crates/apollo_batcher/src/block_builder.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -712,9 +712,9 @@ impl BlockBuilderFactory {
712712
);
713713
let height = block_metadata.block_info.block_number;
714714
let block_builder_config = self.block_builder_config.clone();
715-
let versioned_constants = VersionedConstants::get_versioned_constants(Some(
715+
let versioned_constants = VersionedConstants::get_versioned_constants(
716716
block_builder_config.versioned_constants_overrides,
717-
));
717+
);
718718
let block_context = BlockContext::new(
719719
block_metadata.block_info,
720720
block_builder_config.chain_info,

crates/apollo_batcher_config/src/config.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ pub struct BlockBuilderConfig {
2424
#[serde(deserialize_with = "deserialize_milliseconds_to_duration")]
2525
// TODO(dan): add validation for this field. Probably should be bounded.
2626
pub proposer_idle_detection_delay_millis: Duration,
27-
pub versioned_constants_overrides: VersionedConstantsOverrides,
27+
pub versioned_constants_overrides: Option<VersionedConstantsOverrides>,
2828
}
2929

3030
impl Default for BlockBuilderConfig {
@@ -37,7 +37,9 @@ impl Default for BlockBuilderConfig {
3737
n_concurrent_txs: 100,
3838
tx_polling_interval_millis: 10,
3939
proposer_idle_detection_delay_millis: Duration::from_millis(2000),
40-
versioned_constants_overrides: VersionedConstantsOverrides::default(),
40+
// TODO(Itamar): Change to None once the versioned constants overrides are optional in
41+
// the config schema.
42+
versioned_constants_overrides: Some(VersionedConstantsOverrides::default()),
4143
}
4244
}
4345
}
@@ -69,7 +71,7 @@ impl SerializeConfig for BlockBuilderConfig {
6971
ParamPrivacyInput::Public,
7072
)]));
7173
dump.append(&mut prepend_sub_config_name(
72-
self.versioned_constants_overrides.dump(),
74+
self.versioned_constants_overrides.clone().unwrap_or_default().dump(),
7375
"versioned_constants_overrides",
7476
));
7577
dump

0 commit comments

Comments
 (0)