apollo_gateway: insert optional versioned constant overrides to gateway

[itamar-starkware]

Make versioned_constants_overrides optional in the StatefulTransactionValidatorConfig.

What changed?

• Changed the type of versioned_constants_overrides in StatefulTransactionValidatorConfig from VersionedConstantsOverrides to Option<VersionedConstantsOverrides>
• Updated the default implementation to wrap the default VersionedConstantsOverrides in Some()
• Modified the dump() method to handle the optional case by using unwrap_or_default()
• Updated the StatefulTransactionValidatorFactory to pass the overrides directly without wrapping in `Some()

[reviewable-StarkWare]

This change is 

[itamar-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_node_config: make top level version_constant_overrides optional #10286
• apollo_gateway: insert optional versioned constant overrides to batcher #10285
• apollo_gateway: insert optional versioned constant overrides to gateway #10284 👈 (View in Graphite)
• apollo_batcher: make versioned constants override optional #10236
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

[TzahiTaub]

@TzahiTaub reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @itamar-starkware)

---

crates/apollo_gateway_config/src/config.rs line 225 at r2 (raw file):

            max_nonce_for_validation_skip: Nonce(Felt::ONE),
            min_gas_price_percentage: 100,
            versioned_constants_overrides: Some(VersionedConstantsOverrides::default()),

I think that this should either be None (and the default impl should be removed), or the default should return None.

Code quote:

Some(VersionedConstantsOverrides::default()),

[Yoni-Starkware]

@Yoni-Starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @itamar-starkware and @TzahiTaub)

---

crates/apollo_gateway_config/src/config.rs line 225 at r2 (raw file):

I think that this should either be None (and the default impl should be removed)

+1

[ShahakShama]

@ShahakShama reviewed all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @itamar-starkware, @Itay-Tsabary-Starkware, and @TzahiTaub)

[TzahiTaub]

@TzahiTaub reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @itamar-starkware)