-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_batcher: make versioned constants override optional #10236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main-v0.14.1
Are you sure you want to change the base?
apollo_batcher: make versioned constants override optional #10236
Conversation
eb65633 to
8ad7b5a
Compare
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @TzahiTaub)
crates/blockifier/src/blockifier_versioned_constants.rs line 442 at r1 (raw file):
versioned_constants_overrides: Option<VersionedConstantsOverrides>, ) -> Self { match versioned_constants_overrides {
Since both branches (some/none) end up calling Self::latest_constants().clone(), consider doing that once before. (non-blocking)
Code quote:
match versioned_constants_overrides {|
Previously, Itay-Tsabary-Starkware wrote…
Done |
bc65161 to
03bd26a
Compare
TzahiTaub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TzahiTaub reviewed 2 of 6 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @itamar-starkware)
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yoni-Starkware reviewed 2 of 6 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @itamar-starkware)
03bd26a to
4f24f7a
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShahakShama reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @itamar-starkware)

TL;DR
Made
versioned_constants_overridesan optional field in bothBlockBuilderConfigandStatefulTransactionValidatorConfig.What changed?
versioned_constants_overridesfrom a required field to an optional field (Option<VersionedConstantsOverrides>) in bothBlockBuilderConfigandStatefulTransactionValidatorConfigSome(VersionedConstantsOverrides::default())to maintain backward compatibilityVersionedConstants::get_versioned_constants()to accept anOption<VersionedConstantsOverrides>parameterNoneis provided