Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work bench PR for one-go Core Data extraction into target #24242

Draft
wants to merge 102 commits into
base: trunk
Choose a base branch
from

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Mar 18, 2025

Part of #24165

@dangermattic
Copy link
Collaborator

3 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@mokagio mokagio force-pushed the mokagio/wordpressdata-target-xcdatamodeld branch 5 times, most recently from d2f7b4a to cd16cf0 Compare March 18, 2025 21:01
@mokagio mokagio force-pushed the mokagio/wordpressdata-target-xcdatamodeld branch 2 times, most recently from 2abe7e2 to ff62040 Compare March 19, 2025 18:23
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 19, 2025

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24242-3f29984
Version25.8
Bundle IDorg.wordpress.alpha
Commit3f29984
App Center BuildWPiOS - One-Offs #11754
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 19, 2025

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24242-3f29984
Version25.8
Bundle IDcom.jetpack.alpha
Commit3f29984
App Center Buildjetpack-installable-builds #10780
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

mokagio added 17 commits March 20, 2025 12:33
To much Objective-C code using logic implemented elsewhere in Swift for
us to be able to move the files in two separate Objective-C- and Swift-
only packages.

Refer to #24166 as
an experiment for this that shows the various build failure that even a
partial attempt at moving some files results in.
WordPressAuthenticator does not use it either
Make it easier to extract it in the future.
Just a convenience so it's easier to find them later.
@mokagio mokagio force-pushed the mokagio/wordpressdata-target-xcdatamodeld branch from d1fd942 to 3f29984 Compare March 20, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants