-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work bench PR for one-go Core Data extraction into target #24242
Draft
mokagio
wants to merge
102
commits into
trunk
Choose a base branch
from
mokagio/wordpressdata-target-xcdatamodeld
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
d2f7b4a
to
cd16cf0
Compare
This was referenced Mar 18, 2025
2abe7e2
to
ff62040
Compare
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr24242-3f29984 | |
Version | 25.8 | |
Bundle ID | org.wordpress.alpha | |
Commit | 3f29984 | |
App Center Build | WPiOS - One-Offs #11754 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr24242-3f29984 | |
Version | 25.8 | |
Bundle ID | com.jetpack.alpha | |
Commit | 3f29984 | |
App Center Build | jetpack-installable-builds #10780 |
To much Objective-C code using logic implemented elsewhere in Swift for us to be able to move the files in two separate Objective-C- and Swift- only packages. Refer to #24166 as an experiment for this that shows the various build failure that even a partial attempt at moving some files results in.
WordPressAuthenticator does not use it either
Make it easier to extract it in the future.
Just a convenience so it's easier to find them later.
Only noticed the build failure now because of Xcode only showing a few build errors at a time...
Unfortunately, not enough to remove the dependency
d1fd942
to
3f29984
Compare
These are needed by the WordPressData files.
20348f6
to
6b23c53
Compare
This was referenced Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24165