Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependencies from FormattableContentKit #24266

Open
mokagio opened this issue Mar 20, 2025 · 1 comment
Open

Remove unnecessary dependencies from FormattableContentKit #24266

mokagio opened this issue Mar 20, 2025 · 1 comment

Comments

@mokagio
Copy link
Contributor

mokagio commented Mar 20, 2025

In #24265 I moved more types from the apps targets into FormattableContentKit. To get this done quickly and go back to #24242, I brought in all the dependencies it needed. Those are:

  • Gridicons
  • WordPressKit
  • WordPressUI

I believe it should be possible to replace Gridicons with custom icon(s) and SF Fonts. As for the other libraries, maybe we can extract the few objects used in Kit and UI into Shared?

See also the UIFont extension that was part of the apps targets.

@dangermattic
Copy link
Collaborator

Thanks for reporting! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants