-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert WordPressData from Swift package to Xcode target #24194
Conversation
To much Objective-C code using logic implemented elsewhere in Swift for us to be able to move the files in two separate Objective-C- and Swift- only packages. Refer to #24166 as an experiment for this that shows the various build failure that even a partial attempt at moving some files results in.
Generated by 🚫 Danger |
65c55b2
to
9641248
Compare
WordPressAuthenticator does not use it either
9641248
to
8e7bf7d
Compare
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr24194-4396c99 | |
Version | 25.8 | |
Bundle ID | org.wordpress.alpha | |
Commit | 4396c99 | |
App Center Build | WPiOS - One-Offs #11651 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr24194-4396c99 | |
Version | 25.8 | |
Bundle ID | com.jetpack.alpha | |
Commit | 4396c99 | |
App Center Build | jetpack-installable-builds #10680 |
Is there something in particular worth reviewing? |
Closing in favor of #24242 , for now at least. Sorry @kean I had missed your comment...
The work I've been doing in #24242 is at the target level. My hope is for the target to be a small intermediate step. First, eradicate all the dependencies between what is clearly model code and the rest of the app. To do so, it helps to not have to worry about Objective-C using code defined in Swift itself built on top of Objective-C code. This circular dependency makes moving the code out too. I've been working on it for days and I'm still not done... Once all the code is in WordPressData, and we can work on the target in isolation and with unit tests, restructuring to remove the circular dependencies, or simply rewriting all in Swift should be much faster. I'm 100% on board with the Swift package being the desired end state. |
To much Objective-C code using logic implemented elsewhere in Swift for us to be able to move the files in two separate Objective-C- and Swift- only packages.
Refer to #24166 as an experiment for this that shows the various build failure that even a partial attempt at moving some files results in.
Part of #24165