Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unused imports #24248

Merged
merged 3 commits into from
Mar 19, 2025
Merged

Remove some unused imports #24248

merged 3 commits into from
Mar 19, 2025

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Mar 18, 2025

I keep running into these and feel like I ought to leave a few useful PRs while I slog through moving the files to WordPressData... (#24242)


Fixes #

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dangermattic
Copy link
Collaborator

dangermattic commented Mar 18, 2025

1 Warning
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@mokagio mokagio added this to the 25.9 milestone Mar 18, 2025
@mokagio mokagio self-assigned this Mar 18, 2025
@mokagio mokagio requested review from crazytonyli and kean March 18, 2025 22:09
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 18, 2025

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24248-8faf943
Version25.8
Bundle IDorg.wordpress.alpha
Commit8faf943
App Center BuildWPiOS - One-Offs #11729
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 18, 2025

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24248-8faf943
Version25.8
Bundle IDcom.jetpack.alpha
Commit8faf943
App Center Buildjetpack-installable-builds #10757
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio mokagio marked this pull request as ready for review March 19, 2025 09:46
@mokagio mokagio enabled auto-merge March 19, 2025 09:46
@mokagio mokagio added this pull request to the merge queue Mar 19, 2025
Merged via the queue into trunk with commit 981bca2 Mar 19, 2025
25 checks passed
@mokagio mokagio deleted the mokagio/safe-import-removals branch March 19, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants