starknet_os_flow_tests: add all uncovered regression test

Author: dorimedini-starkware

crates/starknet_os_flow_tests/src/tests.rs

@@ -1,4 +1,5 @@
 use std::collections::{HashMap, HashSet};
+use std::fs;
 use std::sync::{Arc, LazyLock};
 
 use assert_matches::assert_matches;
@@ -12,7 +13,8 @@ use blockifier_test_utils::cairo_versions::{CairoVersion, RunnableCairo1};
 use blockifier_test_utils::calldata::create_calldata;
 use blockifier_test_utils::contracts::FeatureContract;
 use cairo_vm::types::builtin_name::BuiltinName;
-use expect_test::expect;
+use expect_test::{expect, Expect};
+use itertools::Itertools;
 use rstest::rstest;
 use starknet_api::abi::abi_utils::{get_storage_var_address, selector_from_name};
 use starknet_api::block::{BlockInfo, BlockNumber, BlockTimestamp, GasPrice};
@@ -83,6 +85,7 @@ use starknet_committer::block_committer::input::{
 use starknet_committer::patricia_merkle_tree::types::CompiledClassHash;
 use starknet_core::crypto::ecdsa_sign;
 use starknet_crypto::{get_public_key, Signature};
+use starknet_os::hints::enum_definition::AllHints;
 use starknet_os::hints::hint_implementation::deprecated_compiled_class::class_hash::compute_deprecated_class_hash;
 use starknet_os::hints::vars::Const;
 use starknet_os::io::os_output::MessageToL2;
@@ -116,6 +119,27 @@ use crate::utils::{
     update_expected_storage_updates_for_block_hash_contract,
 };
 
+const UNCOVERED_HINTS: Expect = expect![[r#"
+    [
+        "AggregatorHint(DisableDaPageCreation)",
+        "AggregatorHint(GetAggregatorOutput)",
+        "AggregatorHint(GetChainIdFromInput)",
+        "AggregatorHint(GetFeeTokenAddressFromInput)",
+        "AggregatorHint(GetFullOutputFromInput)",
+        "AggregatorHint(GetOsOuputForInnerBlocks)",
+        "AggregatorHint(GetPublicKeysFromAggregatorInput)",
+        "AggregatorHint(GetUseKzgDaFromInput)",
+        "AggregatorHint(WriteDaSegment)",
+        "DeprecatedSyscallHint(DelegateCall)",
+        "DeprecatedSyscallHint(DelegateL1Handler)",
+        "DeprecatedSyscallHint(Deploy)",
+        "OsHint(GetClassHashAndCompiledClassFact)",
+        "OsHint(InitializeAliasCounter)",
+        "OsHint(LoadBottom)",
+        "StatelessHint(SetApToSegmentHashPoseidon)",
+    ]
+"#]];
+
 pub(crate) static NON_TRIVIAL_RESOURCE_BOUNDS: LazyLock<ValidResourceBounds> =
     LazyLock::new(|| {
         ValidResourceBounds::AllResources(AllResourceBounds {
@@ -155,6 +179,27 @@ fn division(#[case] length: usize, #[case] n_parts: usize, #[case] expected_leng
     assert_eq!(actual_lengths, expected_lengths);
 }
 
+/// Tests that the set of uncovered hints is up to date.
+#[rstest]
+fn test_coverage_regression() {
+    // Iterate over all JSON files in the coverage directory.
+    let covered_hints = fs::read_dir("resources/hint_coverage")
+        .unwrap()
+        .map(|entry| entry.unwrap())
+        .flat_map(|entry| {
+            serde_json::from_str::<Vec<AllHints>>(&fs::read_to_string(entry.path()).unwrap())
+                .unwrap()
+        })
+        .unique()
+        .collect::<Vec<_>>();
+    let uncovered_hints = AllHints::all_iter()
+        .filter(|hint| !covered_hints.contains(hint))
+        .map(|hint| format!("{hint:?}"))
+        .sorted()
+        .collect::<Vec<_>>();
+    UNCOVERED_HINTS.assert_debug_eq(&uncovered_hints);
+}
+
 /// Scenario of declaring and deploying the test contract.
 #[rstest]
 #[tokio::test]