feat: introduce handshake to client and gRPC server #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java implementation of numaproj/numaflow-go#42 Signed-off-by: Keran Yang <[email protected]>
whynowy
reviewed
Apr 14, 2023
| FileWriter fileWriter = new FileWriter(filePath, false); | ||
| objectMapper.writeValue(fileWriter, serverInfo); | ||
| FileWriter eofWriter = new FileWriter(filePath, true); | ||
| eofWriter.append("\n").append(ServerInfoConstants.EOF); |
src/main/java/io/numaproj/numaflow/info/ServerInfoAccessorImpl.java
Outdated
Show resolved
Hide resolved
| StringBuilder stringBuilder = new StringBuilder(); | ||
| String line; | ||
| while ((line = bufferedReader.readLine()) != null | ||
| && !line.equals(ServerInfoConstants.EOF)) { |
There was a problem hiding this comment.
I guess \n is for this.
I think it's better to use endWith() to check and trim.
There was a problem hiding this comment.
We don't have to add \n, I just feel it looks prettier when EOF is at a newline :). I also made corresponding changes in numaproj/numaflow-go#48 to make sure the parsing is consistent.
src/main/java/io/numaproj/numaflow/info/ServerInfoAccessorImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
whynowy
approved these changes
Apr 14, 2023
yhl25
reviewed
Apr 15, 2023
| * Please exercise cautions when updating the values below because the exact same values are defined in other Numaflow SDKs | ||
| * to form a contract between server and clients. | ||
| */ | ||
| public enum Language { |
There was a problem hiding this comment.
Any reason why we didn't go with proto? Since it's common among all the sdks we could have kept a common proto file
There was a problem hiding this comment.
+1, we need to standardize our proto location before we do that. today we manually sink it between the repos.
There was a problem hiding this comment.
To be addressed by numaproj/numaflow#693
| * Please exercise cautions when updating the values below because the exact same values are defined in other Numaflow SDKs | ||
| * to form a contract between server and clients. | ||
| */ | ||
| public enum Protocol { |
This was referenced Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java implementation of numaproj/numaflow-go#42
Testing