Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate repository for proto files #691

Open
yhl25 opened this issue Apr 17, 2023 · 2 comments
Open

Separate repository for proto files #691

yhl25 opened this issue Apr 17, 2023 · 2 comments
Labels
enhancement New feature or request gRPC
Milestone

Comments

@yhl25
Copy link
Contributor

yhl25 commented Apr 17, 2023

Problem definition

Currently, we keep the proto files in all the SDKs, if we have to change anything we will need to manually update the proto files in all the SDK repos. Which isn't easy to maintain and may cause version differences.

Proposal

  1. Keep all the proto files in the numaflow repo, and all the SDKs must copy and use *.proto files during build time.

  2. Create a separate repository just to store and track all the *.proto files (daemon.proto, udfs-related protos and info server data could also be defined as a proto) and keep all the generated code in one place and publish them as libraries.

We don't have a lot of proto files at this point but when the number grows it will be difficult to maintain.

@yhl25 yhl25 added enhancement New feature or request nice-to-have Nice to have or Good to have. gRPC labels Apr 17, 2023
@vigith vigith added this to the v0.9 milestone Apr 17, 2023
@vigith vigith removed the nice-to-have Nice to have or Good to have. label Apr 17, 2023
@yhl25
Copy link
Contributor Author

yhl25 commented Apr 17, 2023

@KeranYang
Copy link
Member

Side Note: please also resolve numaproj/numaflow-java#36 (comment) as part of this issue.

@vigith vigith modified the milestones: v0.9, v0.11 Jul 10, 2023
@vigith vigith modified the milestones: v0.11, 1.0 Oct 31, 2023
@whynowy whynowy modified the milestones: 1.0, 1.1 Nov 13, 2023
@whynowy whynowy modified the milestones: 1.1, 1.2 Jan 11, 2024
@vigith vigith modified the milestones: 1.2, 1.3 Mar 19, 2024
@vigith vigith modified the milestones: 1.3, 1.4 Jul 14, 2024
@vigith vigith modified the milestones: 1.4, 1.5 Oct 31, 2024
@vigith vigith modified the milestones: 1.5, 1.6 Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gRPC
Projects
None yet
Development

No branches or pull requests

4 participants