Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize proto file #693

Closed
KeranYang opened this issue Apr 17, 2023 · 1 comment
Closed

Centralize proto file #693

KeranYang opened this issue Apr 17, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@KeranYang
Copy link
Member

KeranYang commented Apr 17, 2023 •
edited
Loading

Summary

Currently we maintain multiple copies of proto file across our 3 supported SDKs, which means when we update the proto definitions, we are required to make exact same changes at 3 places, introducing redundant engineer work.

Consider centralizing the proto file to prevent extra copy.

Notes

please also resolve numaproj/numaflow-java#36 (comment) as part of this issue.

Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.
@KeranYang KeranYang added the enhancement New feature or request label Apr 17, 2023
@KeranYang KeranYang mentioned this issue Apr 17, 2023
Merged
@KeranYang
Copy link
Member Author

Closing this one as it's duplicate with #691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KeranYang