chore: fix some typos #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
KeranYang
changed the title
KeranYang
commented
Apr 14, 2023
Comment on lines
+57
to
+62
| info := &ServerInfo{ | ||
| Protocol: TCP, | ||
| Language: Java, | ||
| Version: "11", | ||
| Metadata: map[string]string{"key1": "value1", "key2": "value2"}, | ||
| } |
There was a problem hiding this comment.
I update this line to match unit test in Java SDK such that I can verify the output files are identical between Go and Java. Feel convenient to keep it.
vigith
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my recent Java implementation, I write the EOF on a newline, just to make it a bit clearer. I make the same changes here in Go SDK to make it consistent for parsing.