Conversation
TomCC7
added this pull request to stack #3922
September 15, 2026 03:58
TomCC7
removed this pull request from stack #3922
September 15, 2026 04:24
TomCC7
added this pull request to stack #4160
September 15, 2026 04:24
TomCC7
force-pushed
the
cc/feat/webxr-audio
branch
from
September 15, 2026 04:37
f3a77fb to
34ea75a
Compare
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
TomCC7
commented
Sep 15, 2026
TomCC7
commented
Sep 15, 2026
TomCC7
commented
Sep 15, 2026
TomCC7
commented
Sep 15, 2026
TomCC7
commented
Sep 15, 2026
TomCC7
force-pushed
the
cc/feat/webxr-audio
branch
from
September 15, 2026 05:20
dee767f to
7fd9dba
Compare
TomCC7
force-pushed
the
cc/feat/webxr-audio
branch
from
September 15, 2026 05:51
a25cc5a to
63661e5
Compare
TomCC7
commented
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution path
Requested collection feedback feature; no separate tracking issue.
Stack: builds on #4088 and targets
cc/feat/abc-policy. The parent owns the shared HTTPS/Hugging Face asset downloader; this PR adds its Kokoro consumer and recording feedback.Problem and behavior
Operators can hear spoken confirmation when recording starts, saves, or discards an episode, either in a WebXR headset or through the computer running attached collection controls. Speech is off by default.
--tts.enabled=truewhen starting the blueprint.dimos imitation collect --tts. This command-local option does not change the running blueprint's configuration.Collection owns phrase wording, confirmed-transition selection, and preparation in
dimos/imitation/collection/prompts.py. WebXR and desktop controls share that helper. Before accepting controls, each enabled consumer prepares all three WAVs and releases the inference engine. Recording callbacks perform no inference. Initialization, attachment snapshots, duplicate events, unchanged status polls, and idle discard commands remain silent.WebXR pushes selected WAV audio over the existing WebSocket; the browser only plays/cancels audio. Desktop controls use nonblocking sounddevice playback on the default output device. New speech interrupts old speech. Detach/disconnect stops playback, and playback errors leave collection controls usable.
Dependencies and assets
The optional
ttsextra uses officialkokoro==0.9.4, PyTorch CPU inference, and officialhexgrad/Kokoro-82Mv1.0 assets at a pinned revision. The default voice isaf_sarah. Missing speech assets download through the parent's shared helper into the dimOS XDG cache. Misaki/spaCy automatically installs the missing English tokenizer with pip or uv on first enabled preparation; installer exits become ordinary startup errors.Cached preparation works offline once the tokenizer is installed. Exact
uv synccan remove the lazily installed tokenizer;uv run --no-syncpreserves the prepared environment. Desktop playback reuses the already-locked sounddevice package; adding it to thettsextra introduces no new locked packages or version changes.How to test
For headset speech, retain the usual recording, task, hardware and camera options:
--armteleopmodule.tts.enabled=trueis the fully qualified WebXR option. TTS module configuration remains limited toenabledandvoice.For desktop speech, start any supported collection stack (including
openyam-teach-collection) with its usual options, then attach:Headset and desktop playback are independently optional.
Manual checklist
/teleop, select Connect, enter XR; connecting is silent.See collection audio usage for setup and full manual instructions.
Validation
AI assistance
Implemented and validated with Codex, including documentation and this draft PR.
Checklist
Agent: Codex