Skip to content

Issue 48298: Align API Filter Operators#157

Merged
RosalineP merged 1 commit intodevelopfrom
fb_Issue48298
Aug 16, 2023
Merged

Issue 48298: Align API Filter Operators#157
RosalineP merged 1 commit intodevelopfrom
fb_Issue48298

Conversation

@RosalineP
Copy link
Contributor

@RosalineP RosalineP commented Aug 16, 2023

Rationale

In the process of adding lineage filter operators to the APIs, I noticed a handful of inconsistencies I'm resolving across the APIs. See related pull requests.

Related Pull Requests

Changes

  • Rearrange ordering of operator types to align with other APIs
  • Add some newlines for comment consistency

Copy link
Contributor

@labkey-nicka labkey-nicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a no-op change? Feel free to merge but you don't need to bump the version if you don't want to.

@RosalineP
Copy link
Contributor Author

Seems like a no-op change? Feel free to merge but you don't need to bump the version if you don't want to.

Yup, this is purely a consistency/alignment update, because the JS API didn't have missing operators, unlike the other API bindings.

@RosalineP RosalineP merged commit dbbb10f into develop Aug 16, 2023
@RosalineP RosalineP deleted the fb_Issue48298 branch August 16, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants