You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the process of adding lineage filter operators to the APIs, I noticed a handful of inconsistencies I'm resolving across the APIs. See related pull requests.
Verify results against UI results at url ending in /list-grid.view?name=<List Name>&query.Field2~Q=one
Lineage Filter Operators
Go into a SM folder
Create a sample type with no manually added fields
Create three samples, accepting defaults. Choose one of them (say it's S-3) and click 'Aliquot Selected', choosing two Aliquots per Parent, and accepting defaults for aliquot creation
Go to /query-executeQuery.view?schemaName=sampleManagement&query.queryName=SourceSamples and add the LSID column
QueryFilter.Types.EXP_LINEAGE_OF:
Execute:
result = api.query.select_rows("sampleManagement", "SourceSamples", filter_array=[QueryFilter("lsid", '{json:[<LSID of S-3>,10]}', QueryFilter.Types.EXP_LINEAGE_OF)])
for row in result["rows"]:
print(str(row['name']))
Verify results:
S-3-1
S-3-2
QueryFilter.Types.EXP_CHILD_OF:
Execute:
result = api.query.select_rows("samples", <Sample Type Name>, filter_array=[QueryFilter("lsid", <LSID of S-3>, QueryFilter.Types.EXP_CHILD_OF)])
for row in result["rows"]:
print(str(row['Name']))
Verify results:
S-3-2
S-3-1
QueryFilter.Types.EXP_PARENT_OF:
Execute:
result = api.query.select_rows("samples", <Sample Type Name>, filter_array=[QueryFilter("lsid", <LSID of S-3-1>, QueryFilter.Types.EXP_PARENT_OF)])
for row in result["rows"]:
print(str(row['Name']))
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Please update the __init__.py with the correct version, and the CHANGE.txt file with the correct date when merging and ping me so I can issue a release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
In the process of adding lineage filter operators to the APIs, I noticed a handful of inconsistencies I'm resolving across the APIs. See related pull requests.
Related Pull Requests
Changes