Skip to content

Issue 48298: Align API Filter Operators #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Issue 48298: Align API Filter Operators #95

merged 2 commits into from
Aug 18, 2023

Conversation

RosalineP
Copy link
Contributor

@RosalineP RosalineP commented Aug 16, 2023

Rationale

In the process of adding lineage filter operators to the APIs, I noticed a handful of inconsistencies I'm resolving across the APIs. See related pull requests.

Related Pull Requests

Changes

  • Update news
  • Rearrange ordering of operator types to align with other APIs
  • Add the following operators:
    • EXP_CHILD_OF
    • EXP_PARENT_OF
    • EXP_LINEAGE_OF

@RosalineP
Copy link
Contributor Author

Manual Test Plan

  • Lineage Filter Operators
    • Go into a SM folder
    • Create a sample type with no manually added fields
    • Create three samples, accepting defaults. Choose one of them (say it's S-3) and click 'Aliquot Selected', choosing two Aliquots per Parent, and accepting defaults for aliquot creation
    • Go to /query-executeQuery.view?schemaName=sampleManagement&query.queryName=SourceSamples and add the LSID column
    • QueryFilter.Types.EXP_LINEAGE_OF:
      • Using the R api, execute a selectRows against sampleManagement.SourceSamples, with a filter containing the components:
        • column: "lsid"
        • value: "{json:[<LSID of S-3>,10]}"
        • filter operator: EXP_LINEAGE_OF
      • Verify results:
        • S-3-1
        • S-3-2
    • QueryFilter.Types.EXP_CHILD_OF:
      • Using the R api, execute a selectRows against samples.<Sample Type Name>, with a filter containing the components:
        • column: "lsid"
        • value: "<LSID of S-3>"
        • filter operator: EXP_CHILD_OF
      • Verify results:
        • S-3-2
        • S-3-1
    • QueryFilter.Types.EXP_PARENT_OF:
      • Using the R api, execute a selectRows against samples.<Sample Type Name>, with a filter containing the components:
        • column: "lsid"
        • value: "<LSID of S-3-1>"
        • filter operator: EXP_PARENT_OF
      • Verify results:
        • S-3

Copy link
Contributor

@cnathe cnathe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. I pushed a couple of changes related to prep'ing for release. Also, I did manual testing and the three operators worked as expected.

@cnathe
Copy link
Contributor

cnathe commented Aug 18, 2023

The following TC artifact has been submitted to CRAN:
Rlabkey_2.12.0.tar.gz

@cnathe
Copy link
Contributor

cnathe commented Aug 18, 2023

CRAN submission has been accepted and updated version is available.

@cnathe cnathe merged commit fef750e into develop Aug 18, 2023
@cnathe cnathe deleted the fb_Issue48298 branch August 18, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants