Skip to content

Issue 48298: Align API Filter Operators #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/labkey/filter/Types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -281,10 +281,6 @@ export const Types: Record<string, IFilterType> = {

MEMBER_OF: registerFilterType('Member Of', null, 'memberof', true, undefined, 'Member Of'),

EXP_CHILD_OF: registerFilterType('Is Child Of', null, 'exp:childof', true, undefined, ' is child of'),
EXP_PARENT_OF: registerFilterType('Is Parent Of', null, 'exp:parentof', true, undefined, ' is parent of'),
EXP_LINEAGE_OF: registerFilterType('In The Lineage Of', null, 'exp:lineageof', true, ',', ' in the lineage of'),

//
// These are the 'no data value' operators
//
Expand Down Expand Up @@ -348,6 +344,7 @@ export const Types: Record<string, IFilterType> = {
//
// Table/Query-wise operators
//

Q: registerFilterType(
'Search',
null,
Expand All @@ -359,11 +356,21 @@ export const Types: Record<string, IFilterType> = {
undefined,
true
),

//
// Ontology operators
//

ONTOLOGY_IN_SUBTREE: registerFilterType('Is In Subtree', null, 'concept:insubtree', true),
ONTOLOGY_NOT_IN_SUBTREE: registerFilterType('Is Not In Subtree', null, 'concept:notinsubtree', true),

//
// Lineage operators
//

EXP_CHILD_OF: registerFilterType('Is Child Of', null, 'exp:childof', true, undefined, ' is child of'),
EXP_PARENT_OF: registerFilterType('Is Parent Of', null, 'exp:parentof', true, undefined, ' is parent of'),
EXP_LINEAGE_OF: registerFilterType('In The Lineage Of', null, 'exp:lineageof', true, ',', ' in the lineage of'),
};

export type JsonType = 'boolean' | 'date' | 'float' | 'int' | 'string';
Expand Down