-
Notifications
You must be signed in to change notification settings - Fork 2
Add Supression Mechanism #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 18 changed files in this pull request and generated no comments.
Files not reviewed (12)
- package.json: Language not supported
- test/files/suppressions1a.json: Language not supported
- test/files/suppressions1b.json: Language not supported
- src/definitions.ts: Evaluated as low risk
- CHANGELOG.md: Evaluated as low risk
- src/rules/rules.ts: Evaluated as low risk
- src/version.ts: Evaluated as low risk
- src/parser.ts: Evaluated as low risk
- src/main.ts: Evaluated as low risk
- src/util.ts: Evaluated as low risk
- test/files/suppressions.yaml: Evaluated as low risk
- README.md: Evaluated as low risk
Comments suppressed due to low confidence (3)
src/suppression.ts:10
- The SuppressionRegistry class and its methods (add, has, propagateSuppression) are not covered by tests. Please add tests to ensure the suppression mechanism works as intended.
export class SuppressionRegistry {
src/html-diff.ts:20
- The comment should be 'Dynamically reads CSS file.'
// Step 4: Dynamically read CSS file
src/html-diff.ts:22
- The hardcoded path to the CSS file may cause issues if the directory structure changes or if the script is run from a different directory. Consider making the path configurable or checking for the file's existence.
const diff2htmlCss = fs.readFileSync("./node_modules/diff2html/bundles/css/diff2html.min.css", "utf8");
fb2391e to
b35a301
Compare
b35a301 to
def995f
Compare
This was referenced Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2.