Skip to content

Conversation

@tjprescott
Copy link
Owner

Closes #2.

@tjprescott tjprescott requested a review from Copilot January 22, 2025 23:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 18 changed files in this pull request and generated no comments.

Files not reviewed (12)
  • package.json: Language not supported
  • test/files/suppressions1a.json: Language not supported
  • test/files/suppressions1b.json: Language not supported
  • src/definitions.ts: Evaluated as low risk
  • CHANGELOG.md: Evaluated as low risk
  • src/rules/rules.ts: Evaluated as low risk
  • src/version.ts: Evaluated as low risk
  • src/parser.ts: Evaluated as low risk
  • src/main.ts: Evaluated as low risk
  • src/util.ts: Evaluated as low risk
  • test/files/suppressions.yaml: Evaluated as low risk
  • README.md: Evaluated as low risk
Comments suppressed due to low confidence (3)

src/suppression.ts:10

  • The SuppressionRegistry class and its methods (add, has, propagateSuppression) are not covered by tests. Please add tests to ensure the suppression mechanism works as intended.
export class SuppressionRegistry {

src/html-diff.ts:20

  • The comment should be 'Dynamically reads CSS file.'
// Step 4: Dynamically read CSS file

src/html-diff.ts:22

  • The hardcoded path to the CSS file may cause issues if the directory structure changes or if the script is run from a different directory. Consider making the path configurable or checking for the file's existence.
const diff2htmlCss = fs.readFileSync("./node_modules/diff2html/bundles/css/diff2html.min.css", "utf8");

@tjprescott tjprescott force-pushed the suppressions branch 14 times, most recently from fb2391e to b35a301 Compare March 12, 2025 17:07
@tjprescott tjprescott merged commit cbb41c9 into main Mar 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suppression Mechanism

2 participants