Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppressions as a checked in resource do not make sense #75

Open
tjprescott opened this issue Mar 18, 2025 · 0 comments
Open

Suppressions as a checked in resource do not make sense #75

tjprescott opened this issue Mar 18, 2025 · 0 comments
Labels
design issues related to the design of the tool itself

Comments

@tjprescott
Copy link
Owner

Suppressions were introduced here (#47). The goal behind having a yaml file is that you could add point suppressions with a rationale, and these point suppressions would be approved as part of the PR by the relevant approvers.

This model has some fundamental flaws, because once the PR is approved, that suppression file will be checked in as an artifact.

Fundamentally, the suppressions only matter between two specific versions of the API. If you suppress something going from version 1 to 2, when you go to version 3, if that item is unchanged from version 2 you have no diff and the suppression does nothing. However, if you DO change something between version 2 and 3, you very likely want to re-review it, but the suppression will suppress the change and allow it in!

So fundamentally, we would need to rethink how this feature works.

@tjprescott tjprescott added the design issues related to the design of the tool itself label Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design issues related to the design of the tool itself
Projects
None yet
Development

No branches or pull requests

1 participant