Implement correct iteration through disjoint enumerated set for infinite set #39443
+122
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the iteration does not touch any finite set that comes after an infinite set.
This fixes the issue.
It tries to not change the existing behavior whenever all element sets are finite, by checking for finiteness.
Meanwhile fix a genuine bug in
root_lattice_realizations
whereDisjointUnionEnumeratedSets([self.positive_real_roots(), self.positive_imaginary_roots()])
is returned, but both sets are infinite, so iterating through it will never reach any element in the second set.📝 Checklist
⌛ Dependencies