Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement correct iteration through disjoint enumerated set for infinite set #39443

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Feb 4, 2025

Previously, the iteration does not touch any finite set that comes after an infinite set.

This fixes the issue.

It tries to not change the existing behavior whenever all element sets are finite, by checking for finiteness.

Meanwhile fix a genuine bug in root_lattice_realizations where DisjointUnionEnumeratedSets([self.positive_real_roots(), self.positive_imaginary_roots()]) is returned, but both sets are infinite, so iterating through it will never reach any element in the second set.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Feb 4, 2025

Documentation preview for this PR (built with commit 8a91beb; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729 user202729 marked this pull request as draft February 4, 2025 03:47
@user202729 user202729 marked this pull request as ready for review February 4, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant