Skip to content

Update backtrace in Cargo.lock #140705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2025
Merged

Update backtrace in Cargo.lock #140705

merged 1 commit into from
May 10, 2025

Conversation

LegNeato
Copy link
Contributor

@LegNeato LegNeato commented May 6, 2025

Ran cargo update -p backtrace. This is needed to forward port the rust-gpu compiler backend.

Subsumes #140631. Was supposed to be fixed by #140353, but there were test failures and the backtrace update was backed out.

@rustbot
Copy link
Collaborator

rustbot commented May 6, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 6, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@LegNeato
Copy link
Contributor Author

LegNeato commented May 6, 2025

(I haven't fixed any test failures yet, want to see if they still exist)

@Berrysoft Berrysoft mentioned this pull request May 7, 2025
1 task
@Berrysoft
Copy link
Contributor

Could you update it again to 0.3.75? It was released 9 hours ago.

Ran `cargo update -p backtrace`. This is needed to forward port the rust-gpu compiler backend.

Subsumes rust-lang#140631. Was supposed
to be fixed by rust-lang#140353, but there
were test failures and the fix was backed out.
@LegNeato
Copy link
Contributor Author

LegNeato commented May 8, 2025

@Berrysoft done! Thanks for pointing that out.

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented May 9, 2025

📌 Commit d4862eb has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2025
@bors
Copy link
Collaborator

bors commented May 10, 2025

⌛ Testing commit d4862eb with merge bfb44c8...

@bors
Copy link
Collaborator

bors commented May 10, 2025

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing bfb44c8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 10, 2025
@bors bors merged commit bfb44c8 into rust-lang:master May 10, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 10, 2025
Copy link

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c6faa1b (parent) -> bfb44c8 (this PR)

Test differences

Show 33146 test diffs

Stage 1

  • f64::test_exp2: [missing] -> pass (J0)
  • fmt::builders::debug_tuple::test_single: [missing] -> pass (J0)
  • intrinsics::carrying_mul_add_fallback_i128: [missing] -> pass (J0)
  • io::buffered::tests::line_full_buffer_flushed: [missing] -> pass (J0)
  • io::cursor::tests::seek_past_i64: [missing] -> pass (J0)
  • io::cursor::tests::test_mem_writer: [missing] -> pass (J0)
  • io::error::tests::test_custom_error_packing: [missing] -> pass (J0)
  • iter::adapters::array_chunks::test_iterator_array_chunks_next_and_next_back: [missing] -> pass (J0)
  • iter::sources::test_once: [missing] -> pass (J0)
  • iter::traits::iterator::test_iterator_len: [missing] -> pass (J0)
  • mpmc::chan_gone_concurrent: [missing] -> pass (J0)
  • mpsc_sync::oneshot_single_thread_recv_chan_close: [missing] -> pass (J0)
  • num::flt2dec::strategy::dragon::test_to_shortest_str: [missing] -> pass (J0)
  • num::i8::test_abs: [missing] -> pass (J0)
  • num::test_try_i16u32: [missing] -> pass (J0)
  • option::test_collect: [missing] -> pass (J0)
  • result::test_into_ok: [missing] -> pass (J0)
  • slice::slice_index::range_neg_width::index_mut_fail: [missing] -> pass (J0)
  • slice::test_chunks_exact_mut_remainder: [missing] -> pass (J0)
  • str::slice_index::range_neg_width::pass: [missing] -> pass (J0)
  • string::test_replace_range_inclusive_range: [missing] -> pass (J0)
  • sync::test_clone_from_slice: [missing] -> pass (J0)
  • back::apple::tests::lookup_developer_dir: [missing] -> pass (J1)
  • back::link::verify_codegen_ssa_linker_output_0: [missing] -> pass (J1)
  • errors::autodiff::verify_builtin_macros_autodiff_width_33: [missing] -> pass (J1)
  • errors::verify_ast_lowering_coroutine_too_many_parameters_5: [missing] -> pass (J1)
  • errors::verify_codegen_ssa_invalid_monomorphization_simd_shuffle_106: [missing] -> pass (J1)
  • errors::verify_hir_typeck_ctor_is_private_21: [missing] -> pass (J1)
  • errors::verify_hir_typeck_functional_record_update_on_non_struct_5: [missing] -> pass (J1)
  • errors::verify_interface_out_dir_error_10: [missing] -> pass (J1)
  • errors::verify_mir_dataflow_peek_must_be_not_temporary_6: [missing] -> pass (J1)
  • errors::verify_passes_naked_functions_must_naked_asm_134: [missing] -> pass (J1)
  • errors::verify_trait_selection_rustc_on_unimplemented_expected_one_predicate_in_not_11: [missing] -> pass (J1)
  • html::length_limit::tests::empty: [missing] -> pass (J1)
  • mir::interpret::allocation::init_mask::tests::grow_within_unused_bits_with_full_overwrite: [missing] -> pass (J1)
  • spec::tests::aarch64_unknown_nto_qnx800: [missing] -> pass (J1)
  • spec::tests::armv7_unknown_linux_ohos: [missing] -> pass (J1)
  • tests::align_constants: [missing] -> pass (J1)
  • iter::bench_enumerate_chain_ref_sum: [missing] -> pass (J2)
  • net::tcp::tests::write_vectored: [missing] -> pass (J2)
  • num::int_log::u128_log10_random_small: [missing] -> pass (J2)
  • os::unix::net::tests::test_unix_datagram_connect_to_recv_addr: [missing] -> pass (J2)
  • pattern::starts_with_str: [missing] -> pass (J2)
  • slice::ends_with_single_element: [missing] -> pass (J2)
  • slice::zero_1kb_from_elem: [missing] -> pass (J2)
  • sort::tests::stable::self_cmp_cell_i32_random_d2: [missing] -> pass (J2)
  • sort::tests::unstable::deterministic_i32_descending: [missing] -> pass (J2)
  • str::split_a_str::short_pile_of_poo: [missing] -> pass (J2)
  • str::starts_with_ascii_char::short_mixed: [missing] -> pass (J2)
  • str::to_lowercase::short_pile_of_poo: [missing] -> pass (J2)
  • term::terminfo::parm::tests::test_comparison_ops: [missing] -> pass (J2)
  • tests::run_include_ignored_option: [missing] -> pass (J2)
  • vec::bench_dedup_none_100: [missing] -> pass (J2)
  • sort::tests::unstable::observable_is_less_ascending: [missing] -> ignore (J3)

Stage 2

  • cell::refcell_format: pass -> [missing] (J0)
  • cell::refcell_replace_borrows: pass -> [missing] (J0)
  • collections::btree::map::tests::test_cursor_mut_insert_after_2: pass -> [missing] (J0)
  • iter::adapters::enumerate::test_iterator_enumerate_nth: pass -> [missing] (J0)
  • iter::adapters::skip::test_iterator_skip_count: pass -> [missing] (J0)
  • iter::traits::iterator::test_eq_by: pass -> [missing] (J0)
  • mem::uninit_write_iter_empty: pass -> [missing] (J0)
  • mpsc::smoke_port_gone: pass -> [missing] (J0)
  • num::flt2dec::strategy::grisu::shortest_sanity_test: pass -> [missing] (J0)
  • num::test_i32f64: pass -> [missing] (J0)
  • num::test_try_u16i128: pass -> [missing] (J0)
  • num::u16::test_le: pass -> [missing] (J0)
  • result::test_unwrap_or_else: pass -> [missing] (J0)
  • rwlock::test_get_cloned_poison: pass -> [missing] (J0)
  • slice::slice_index::rangetoinclusive_len::index_fail: pass -> [missing] (J0)
  • sync::test_from_box: pass -> [missing] (J0)
  • thread::tests::test_try_panic_any_message_owned_str: pass -> [missing] (J0)
  • vec::test_slice_from_ref: pass -> [missing] (J0)
  • errors::verify_mir_build_leading_irrefutable_let_patterns_8: pass -> [missing] (J1)
  • errors::verify_parse_async_use_order_incorrect_59: pass -> [missing] (J1)
  • errors::verify_parse_inclusive_range_match_arrow_40: pass -> [missing] (J1)
  • errors::verify_parse_invalid_offset_of_168: pass -> [missing] (J1)
  • errors::verify_parse_left_arrow_operator_29: pass -> [missing] (J1)
  • errors::verify_passes_doc_inline_only_use_36: pass -> [missing] (J1)
  • html::escape::tests::escape_body_text_with_wbr: pass -> [missing] (J1)
  • html::tests::href_relative_parts_parent_module: pass -> [missing] (J1)
  • lints::verify_lint_unused_macro_definition_110: pass -> [missing] (J1)
  • lints::verify_lint_variant_size_differences_88: pass -> [missing] (J1)
  • owned_slice::tests::send_sync: pass -> [missing] (J1)
  • profiling::tests::no_rss: pass -> [missing] (J1)
  • spec::tests::aarch64_apple_ios_macabi: pass -> [missing] (J1)
  • spec::tests::armv7a_none_eabihf: pass -> [missing] (J1)
  • spec::tests::powerpc_unknown_openbsd: pass -> [missing] (J1)
  • spec::tests::riscv64imac_unknown_none_elf: pass -> [missing] (J1)
  • ascii::is_ascii::unaligned_both_long::case02_align_to: pass -> [missing] (J2)
  • btree::set::clone_100_and_remove_half: pass -> [missing] (J2)
  • fs::tests::sync_doesnt_kill_anything: pass -> [missing] (J2)
  • iter::bench_skip_sum: pass -> [missing] (J2)
  • net::udp::tests::test_read_timeout: pass -> [missing] (J2)
  • process::tests::test_process_output_error: pass -> [missing] (J2)
  • slice::rotate_huge_by9199_u64: pass -> [missing] (J2)
  • slice::sort_large_big: pass -> [missing] (J2)
  • slice::split_off_mut_in_bounds_max_range_to: pass -> [missing] (J2)
  • sort::tests::stable::correct_u128_random_d2: pass -> [missing] (J2)
  • sort::tests::unstable::self_cmp_i32_random_s95: pass -> [missing] (J2)
  • vec::bench_extend_from_slice_1000_1000: pass -> [missing] (J2)

(and 16500 additional test diffs)

Additionally, 16546 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard bfb44c8155dc102358deeb27acef44abe030b30e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 1592.0s -> 4046.1s (154.1%)
  2. test-various: 2295.1s -> 4099.5s (78.6%)
  3. x86_64-gnu-aux: 4179.3s -> 5781.3s (38.3%)
  4. dist-x86_64-apple: 10805.0s -> 6995.0s (-35.3%)
  5. dist-apple-various: 7302.4s -> 5757.7s (-21.2%)
  6. dist-arm-linux: 4679.9s -> 5507.1s (17.7%)
  7. aarch64-apple: 3429.0s -> 3922.7s (14.4%)
  8. dist-various-1: 4401.2s -> 4753.6s (8.0%)
  9. dist-powerpc-linux: 5329.4s -> 5105.1s (-4.2%)
  10. x86_64-gnu-debug: 6230.7s -> 5999.1s (-3.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bfb44c8): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
1.0% [1.0%, 1.0%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.0% [1.0%, 1.0%] 1

Max RSS (memory usage)

Results (primary -0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.5% [0.4%, 1.3%] 15
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.8% [-5.0%, -0.5%] 5
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.0% [-5.0%, 1.3%] 20

Cycles

Results (primary -0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.1% [0.4%, 2.2%] 3
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.7% [-2.0%, -1.6%] 3
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.3% [-2.0%, 2.2%] 6

Binary size

Results (secondary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Bootstrap: 773.028s -> 772.768s (-0.03%)
Artifact size: 365.81 MiB -> 365.84 MiB (0.01%)

@rustbot rustbot added the perf-regression Performance regression. label May 10, 2025
@LegNeato LegNeato deleted the backtracelock branch May 10, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants