Skip to content

Update miniz_oxide dependency of coverage_dump #140899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2025

Conversation

oyvindln
Copy link
Contributor

@oyvindln oyvindln commented May 10, 2025

This was the final subproject that depended on miniz_oxide 0.7.x after the rest were when updating the backtrace-rs dependency in in #140705. Older versions of miniz_oxide got hit by a serious performance regression in rust 1.82 (which has been worked around in more recent versions of the library) so should really be avoided if possible (granted it only affects compression so not sure if it had much impact in practice here, though there have also been some other performance improvements since .)

This also means no longer having to build two versions of miniz_oxide as everything can now use the same version, and no longer needing to build both adler and adler2

@rustbot
Copy link
Collaborator

rustbot commented May 10, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 10, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@jieyouxu
Copy link
Member

r? @Zalathar

@rustbot rustbot assigned Zalathar and unassigned Mark-Simulacrum May 11, 2025
@Zalathar
Copy link
Contributor

Ooh, nice. Thanks for doing this.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 11, 2025

📌 Commit 5bd3d0e has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2025
@bors
Copy link
Collaborator

bors commented May 11, 2025

⌛ Testing commit 5bd3d0e with merge ce7e97f...

@bors
Copy link
Collaborator

bors commented May 11, 2025

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing ce7e97f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 11, 2025
@bors bors merged commit ce7e97f into rust-lang:master May 11, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 11, 2025
Copy link

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3528a5b (parent) -> ce7e97f (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ce7e97f7371af47e0786f74aa169f6ac9473ff4e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-1: 7288.9s -> 5994.6s (-17.8%)
  2. x86_64-msvc-ext3: 7557.6s -> 8715.0s (15.3%)
  3. dist-apple-various: 7234.9s -> 6144.3s (-15.1%)
  4. dist-x86_64-apple: 9332.1s -> 7941.0s (-14.9%)
  5. dist-arm-linux: 5369.9s -> 4749.3s (-11.6%)
  6. x86_64-msvc-ext2: 5637.9s -> 6047.9s (7.3%)
  7. x86_64-mingw-1: 9570.5s -> 8880.5s (-7.2%)
  8. aarch64-apple: 3865.9s -> 4096.9s (6.0%)
  9. i686-msvc-1: 9801.1s -> 9289.4s (-5.2%)
  10. x86_64-gnu-llvm-20-2: 5658.3s -> 5924.4s (4.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ce7e97f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.5%, secondary 2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.3% [0.4%, 2.5%] 4
Regressions ❌
(secondary)
2.5% [0.5%, 5.0%] 3
Improvements ✅
(primary)
-1.0% [-1.5%, -0.5%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.5% [-1.5%, 2.5%] 6

Cycles

Results (primary -0.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.5% [-0.5%, -0.5%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.5% [-0.5%, -0.5%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 773.066s -> 772.51s (-0.07%)
Artifact size: 365.42 MiB -> 365.40 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants