-
Notifications
You must be signed in to change notification settings - Fork 13.3k
[rustdoc] Add new --book-location
option to add a link to associated guide and generate it if local
#139769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
This comment has been minimized.
This comment has been minimized.
15e7374
to
1aefb85
Compare
This comment has been minimized.
This comment has been minimized.
1aefb85
to
bcb5ed2
Compare
This comment has been minimized.
This comment has been minimized.
bcb5ed2
to
cad5667
Compare
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
This comment has been minimized.
This comment has been minimized.
cad5667
to
3388b0b
Compare
This PR modifies cc @jieyouxu |
Finally fixed all tidy errors. :') |
This option adds the possibility to provide a path or a URL to the associated guide of this crate in the crate-level doc page. If the provided argument is a path, then the guide is generated using the
mdbook
crate.It looks like this:
You can give it a try here.
It'll need an FCP before getting merged.
Also I need to add tests when the argument is a path but I'll wait for the feature form to be final before doing it to prevent doing it more than once. 😄
cc @notriddle
r? @camelid