Fix Ruby 3.1 on CI #2553
Merged
Fix Ruby 3.1 on CI #2553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
commented
Jan 11, 2022
| gem 'net-smtp', require: false | ||
| gem 'net-imap', require: false | ||
| gem 'net-pop', require: false | ||
| end |
There was a problem hiding this comment.
Well, it's understandeable that this didn't help. The whole thing also needs to be replicated on the when nil, false, "" branch, and when /stable$/.
It's not needed in when /main/, since main goes for the ongoing Rails 7.1 and it's fixed there.
I intend to move this outside of case and remove the Rails version check.
There was a problem hiding this comment.
When you get it sorted feel free to use dev tools to try to remove the check
pirj
added a commit
that referenced
this pull request
Jan 11, 2022
Follow-up to #2553 I've quite missed the fact that dependent builds specify no `RAILS_VERSION`, and another `case` branch was used, causing `net-` dependency failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally by @petergoldstein from #2552
net-*gems were demoted, and while Rails 7.0.1 explicitly requires them, earlier versions don't.Purposed to fix other RSpec repos'
rspec-railssub-build on Ruby 3.1, see e.g. https://github.com/rspec/rspec-support/pull/527/files#diff-bde1ccb98959c0287bdc7bc203ab3a0dab55c1841be3d7a9678cd42a50670141R108