Skip to content

Fix Ruby 3.1 on CI #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2022
+11 −0
Merged

Fix Ruby 3.1 on CI #2553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Gemfile-rails-dependencies
View file
Original file line number Diff line number Diff line change
@@ -25,4 +25,15 @@ else
gem "puma"
gem 'activerecord-jdbcsqlite3-adapter', platforms: [:jruby]
gem 'selenium-webdriver', require: false

# This is required for Ruby 3.1 and Rails 6.1.x as of time
# of writing, because in Ruby 3.1 these gems are no longer
# automatically included. This issue was fixed on the Rails
# side in Rails 7.0.1, but is not yet fixed in the Rails 6.1.x
# branch. Discussion can be found here - https://github.com/mikel/mail/pull/1439
if RUBY_VERSION >= '3.1' && version.split(' ').last < '7.0'
gem 'net-smtp', require: false
gem 'net-imap', require: false
gem 'net-pop', require: false
end
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it's understandeable that this didn't help. The whole thing also needs to be replicated on the when nil, false, "" branch, and when /stable$/.
It's not needed in when /main/, since main goes for the ongoing Rails 7.1 and it's fixed there.

I intend to move this outside of case and remove the Rails version check.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you get it sorted feel free to use dev tools to try to remove the check

end