Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Updates from rspec-dev (2022-01-10) #2928

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Jan 10, 2022

These are some updates, generated from rspec-dev's rake tasks.

@JonRowe JonRowe force-pushed the update-ci-build-scripts-2022-01-10-for-main branch from e0b5e0e to 26727c3 Compare January 10, 2022 22:24
@JonRowe
Copy link
Member Author

JonRowe commented Jan 10, 2022

@pirj I'm probably going to merge these 4 prs, they do this:

  • Add Ruby 3.1
  • Extract rubocop to its own job, we only really had it within the other builds as a "hangover" from Travis days where you couldn't specify multiple checks so easily, I don't think we need to check every ruby for rubocop compliance, this will make it easier to upgrade, its currently on Ruby 3.
  • Skip the rspec-rails cross build on Ruby 3.1 until 6.1 supports it or we swap the default build to 7.

The only remaining "consistent" failure is ruby-head, the windows builds do just randomly segfault sometimes.

@pirj
Copy link
Member

pirj commented Jan 10, 2022

we need to check every ruby for rubocop compliance

That's fine. It's getting late, and I'm struggling to come up with an example code that RuboCop would detect on a certain Ruby version as incompatible, while specs would pass. And this will really ease up RuboCop version update (cc @petergoldstein)

Skip the rspec-rails cross build on Ruby 3.1 until 6.1 supports it or we swap the default build to 7

rspec/rspec-rails#2553 fixes net-* dependency problem.
We still probably have to switch ~> 6.0.0 to ~> 6.1.0 in when nil, false, "" in Gemfile-rails-dependencies.

@pirj
Copy link
Member

pirj commented Jan 11, 2022

rspec/rspec-rails#2553 fixes net-* dependency problem.

It didn't.

Let's merge those 4 PRs and get this problem out of the way 👍

@JonRowe JonRowe merged commit 56f9edf into main Jan 11, 2022
@JonRowe JonRowe deleted the update-ci-build-scripts-2022-01-10-for-main branch January 11, 2022 08:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants