-
Notifications
You must be signed in to change notification settings - Fork 162
upgrade colcon-cargo in pixi.toml for windows CI #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Windows CI builds now. The others don't but that's not due to this PR so that must be something else. @esteve fyi |
From a quick peek into the CI logs, it looks like the system is having trouble finding the Do you know of anything that might cause temporary disruption in finding packages? This PR shouldn't affect that, right? |
The package name problem is another side effect of colcon/colcon-cargo#59 I fixed it in #480 . These are the relevant commits that you can copy into this PR: [1][2] |
Thanks! The ubuntu CI is still failing though on the tests so not sure what can be a fix for that though. But indeed, this PR by itself doesn't influence those (at least it shouldn't :) ) |
It looks like parameter_demo still needs to be renamed to |
The changes look good, and we have a passing CI! Thank you very much for your help! Merging... |
In this PR of colcon-cargo, colcon-core version has been locked to be higher than 0.19: colcon/colcon-cargo#59
Since the pixi.toml on the ros2 repo locks the colcon-cargo pypi to be less than 0.18 this is causing a dependency issue.
This PR fixes our CI temporary but a PR needs to be made to ROS2 repo pixi.toml file at least to fix this in the long term.