Skip to content

Timers #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Timers #480

wants to merge 9 commits into from

Conversation

mxgrey
Copy link
Collaborator

@mxgrey mxgrey commented May 14, 2025

This PR splits the timer.rs module out of #446 so it can be reviewed separately after #446 is merged.

@mxgrey mxgrey mentioned this pull request May 14, 2025
Signed-off-by: Michael X. Grey <[email protected]>
@mxgrey mxgrey force-pushed the worker_with_timers branch from a2af202 to 2d20c4e Compare June 29, 2025 06:16
mxgrey added 6 commits June 29, 2025 15:55
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
@mxgrey
Copy link
Collaborator Author

mxgrey commented Jun 29, 2025

@esteve This is embarrassing since I was vocally supportive of committing the cargo lockfiles, but now I'm thinking that might have been a mistake. I'm noticing two issues in practice:

  1. Every run of colcon build seems to update the lockfiles. In fact a bunch of different tools that I use on a regular basis are triggering automatic updates of the lockfiles. It's creating a lot of unnecessary churn in the git history.
  2. More crucially, I'm seeing this error happen in the minimum supported Rust compiler version CI. Essentially any new lockfiles that get generated and committed will be incompatible with the "Minimal" CI.

I've had to resort to manually deleting the Cargo.lock for the worker_demo, logging_demo, and now timer_demo examples each time I commit in order to get the Minimal CI to pass.

I'd suggest we remove the lockfiles from the git history or else this is going to cause a great deal of ongoing annoyance where everyone is constantly reverting lockfiles before committing 😞

Signed-off-by: Michael X. Grey <[email protected]>
@mxgrey
Copy link
Collaborator Author

mxgrey commented Jun 29, 2025

@knmcguire Sorry to summon you into this random PR but it seems a new CI failure has popped up for Windows.

I have a feeling this is due to this recent PR in colcon-cargo, and we'll see this failure show up for the main branch on Tuesday during its weekly CI run.

@knmcguire
Copy link
Contributor

Thanks for letting me know @esteve ! I don't get messages of the CI failures on windows so I was unaware of this. I'll dig into it and make a PR

The cargo lock did solve some things for the windows CI though so if that is removed we might need to deal with those failures, but let's see when it comes.

@knmcguire
Copy link
Contributor

See this PR: #495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants