-
Notifications
You must be signed in to change notification settings - Fork 162
Timers #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Timers #480
Conversation
Signed-off-by: Michael X. Grey <[email protected]>
a2af202
to
2d20c4e
Compare
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
@esteve This is embarrassing since I was vocally supportive of committing the cargo lockfiles, but now I'm thinking that might have been a mistake. I'm noticing two issues in practice:
I've had to resort to manually deleting the I'd suggest we remove the lockfiles from the git history or else this is going to cause a great deal of ongoing annoyance where everyone is constantly reverting lockfiles before committing 😞 |
Signed-off-by: Michael X. Grey <[email protected]>
@knmcguire Sorry to summon you into this random PR but it seems a new CI failure has popped up for Windows. I have a feeling this is due to this recent PR in colcon-cargo, and we'll see this failure show up for the |
Thanks for letting me know @esteve ! I don't get messages of the CI failures on windows so I was unaware of this. I'll dig into it and make a PR The cargo lock did solve some things for the windows CI though so if that is removed we might need to deal with those failures, but let's see when it comes. |
See this PR: #495 |
This PR splits the
timer.rs
module out of #446 so it can be reviewed separately after #446 is merged.