dracut: depend on net-lib not ifcfg #6125
Conversation
AdamWill
force-pushed
the
dracut-no-ifcfg
branch
from
e7f0a46 to
df91f29
Compare
|
/kickstart-test --testtype smoke |
|
ping? |
|
/kickstart-test --testtype smoke |
| @@ -8,7 +8,7 @@ check() { | |||
| } | |||
|
|
|||
| depends() { | |||
| echo livenet nfs img-lib convertfs ifcfg | |||
| echo livenet nfs img-lib convertfs net-lib | |||
There was a problem hiding this comment.
I do not mean to slow down progress here, but this could be further simplified to
livenet nfs convertfs .
img-lib and net-lib are already transitive dependencies of livenet.
Keeping the list of dependencies to the "top level" dracut modules, could avoid future compat issues like this one.
There was a problem hiding this comment.
personally, I subscribe to the opinion that direct dependencies should always be explicit. Assuming anaconda directly uses img-lib, it is correct for anaconda to have a direct dep on it. Relying on transitive dependencies is fundamentally unsafe - sure, livenet uses img-lib now, but what if livenet is later changed upstream to not use img-lib? anaconda would suddenly break.
There was a problem hiding this comment.
@AdamWill agreed. It seems img-lib is directly used, but net-lib is not.
There was a problem hiding this comment.
as noted in the commit message, the anaconda module uses save_netinfo, which is from net-lib.
There was a problem hiding this comment.
Thanks.
In that case I would have also sourced net-lib from anaconda-ifcfg.sh (which is why I missed it).
Also noticed that anaconda-lib.sh sources url-lib which might warrant to have url-lib listed as a direct dependency.
These changes might be out of scope for this kind of unblocking PR..
There was a problem hiding this comment.
yes, i think those are out of scope for this PR.
ifcfg is gone in dracut-ng 204. Looking at the module and its history, I'm pretty sure we don't actually use anything from the ifcfg module any more. anaconda-ifcfg.sh only uses save_netinfo, which is in net-lib. So let's turn the ifcfg dep into a net-lib dep instead. If I missed anything and we really are still relying on the ifcfg module then we need to fix that, since it's gone now. Resolves: rhbz#2343125
AdamWill
force-pushed
the
dracut-no-ifcfg
branch
from
df91f29 to
f58e87a
Compare
|
/kickstart-test --testtype smoke |
In RHEL 10 and Fedora 42, the ifcfg module was replaced by net-lib. Anaconda changes: - rhinstaller/anaconda#6125 - rhinstaller/anaconda#6155 Remove ifcfg from common anaconda dracut stage modules and add either ifcfg or net-lib to each installer based on distro version.
In RHEL 10 and Fedora 42, the ifcfg module was replaced by net-lib. Anaconda changes: - rhinstaller/anaconda#6125 - rhinstaller/anaconda#6155 Remove ifcfg from common anaconda dracut stage modules and add either ifcfg or net-lib to each installer based on distro version.
In RHEL 10 and Fedora 42, the ifcfg module was replaced by net-lib. Anaconda changes: - rhinstaller/anaconda#6125 - rhinstaller/anaconda#6155 Remove ifcfg from common anaconda dracut stage modules and add either ifcfg or net-lib to each installer based on distro version.
In RHEL 10 and Fedora 42, the ifcfg module was replaced by net-lib. Anaconda changes: - rhinstaller/anaconda#6125 - rhinstaller/anaconda#6155 Remove ifcfg from common anaconda dracut stage modules and add either ifcfg or net-lib to each installer based on distro version.
ifcfg is gone in dracut-ng 204. Looking at the module and its history, I'm pretty sure we don't actually use anything from the ifcfg module any more. anaconda-ifcfg.sh only uses save_netinfo, which is in net-lib. So let's turn the ifcfg dep into a net-lib dep instead.
If I missed anything and we really are still relying on the ifcfg module then we need to fix that, since it's gone now.