-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dracut: depend on net-lib not ifcfg #6157
dracut: depend on net-lib not ifcfg #6157
Conversation
/kickstart-test --testtype smoke |
Hm, let me look at the failed smoke tests. |
/build-image |
Images built based on commit 43d3e7a:
Download the images from the bottom of the job status page. |
/kickstart-test --testtype smoke |
Latest F42 iso works for me with the failing tests. It could be useful to build the iso here to be able to debug locally but we'd need to rebase the PR on the 2dbeea4. |
ifcfg is gone in dracut-ng 204. Looking at the module and its history, I'm pretty sure we don't actually use anything from the ifcfg module any more. anaconda-ifcfg.sh only uses save_netinfo, which is in net-lib. So let's turn the ifcfg dep into a net-lib dep instead. If I missed anything and we really are still relying on the ifcfg module then we need to fix that, since it's gone now. Resolves: rhbz#2343125
43d3e7a
to
1f74f00
Compare
/kickstart-test --testtype smoke |
/build-image --boot.iso |
Images built based on commit 1f74f00:
Download the images from the bottom of the job status page. |
The same exact tests fail on other PRs: #6159: see https://github.com/rhinstaller/anaconda/actions/runs/13375544487/job/37353896587 It can't be related. |
Tests pass locally with the downloaded ISO from 42. Also this is not specific to this PR. Let's merge this and debug failures afterwards. |
ifcfg is gone in dracut-ng 204. Looking at the module and its history, I'm pretty sure we don't actually use anything from the ifcfg module any more. anaconda-ifcfg.sh only uses save_netinfo, which is in net-lib. So let's turn the ifcfg dep into a net-lib dep instead.
If I missed anything and we really are still relying on the ifcfg module then we need to fix that, since it's gone now.
Resolves: rhbz#2343125
Port of PR: #6125