Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dracut: depend on net-lib not ifcfg #6157

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

M4rtinK
Copy link
Contributor

@M4rtinK M4rtinK commented Feb 12, 2025

ifcfg is gone in dracut-ng 204. Looking at the module and its history, I'm pretty sure we don't actually use anything from the ifcfg module any more. anaconda-ifcfg.sh only uses save_netinfo, which is in net-lib. So let's turn the ifcfg dep into a net-lib dep instead.

If I missed anything and we really are still relying on the ifcfg module then we need to fix that, since it's gone now.

Resolves: rhbz#2343125

Port of PR: #6125

@M4rtinK M4rtinK added the f42 Fedora 42 label Feb 12, 2025
@KKoukiou KKoukiou added f43 f42 Fedora 42 release-blocker and removed f42 Fedora 42 f43 labels Feb 13, 2025
@KKoukiou
Copy link
Contributor

/kickstart-test --testtype smoke

@rvykydal
Copy link
Contributor

Hm, let me look at the failed smoke tests.

@rvykydal
Copy link
Contributor

/build-image

Copy link

Images built based on commit 43d3e7a:

  • boot.iso: failure

Download the images from the bottom of the job status page.

@rvykydal
Copy link
Contributor

/kickstart-test --testtype smoke

@rvykydal
Copy link
Contributor

rvykydal commented Feb 14, 2025

Hm, let me look at the failed smoke tests.

Latest F42 iso works for me with the failing tests. It could be useful to build the iso here to be able to debug locally but we'd need to rebase the PR on the 2dbeea4.

ifcfg is gone in dracut-ng 204. Looking at the module and its
history, I'm pretty sure we don't actually use anything from the
ifcfg module any more. anaconda-ifcfg.sh only uses save_netinfo,
which is in net-lib. So let's turn the ifcfg dep into a net-lib
dep instead.

If I missed anything and we really are still relying on the ifcfg
module then we need to fix that, since it's gone now.

Resolves: rhbz#2343125
@M4rtinK M4rtinK force-pushed the fedora-42-dracut-no-ifcfg branch from 43d3e7a to 1f74f00 Compare February 17, 2025 11:42
@rvykydal
Copy link
Contributor

/kickstart-test --testtype smoke

@jkonecny12
Copy link
Member

/build-image --boot.iso

Copy link

Images built based on commit 1f74f00:

  • boot.iso: success

Download the images from the bottom of the job status page.

@KKoukiou
Copy link
Contributor

KKoukiou commented Feb 18, 2025

The same exact tests fail on other PRs: #6159: see https://github.com/rhinstaller/anaconda/actions/runs/13375544487/job/37353896587

It can't be related.

@KKoukiou
Copy link
Contributor

Tests pass locally with the downloaded ISO from 42. Also this is not specific to this PR. Let's merge this and debug failures afterwards.

@KKoukiou KKoukiou merged commit 70dad9e into rhinstaller:fedora-42 Feb 18, 2025
13 of 15 checks passed
@KKoukiou KKoukiou deleted the fedora-42-dracut-no-ifcfg branch February 18, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants