dracut: depend on net-lib not ifcfg #6155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kickstart-test --testtype smoke |
|
LGTM, makes sense; the module is here: https://github.com/redhat-plumbers/dracut-rhel10/tree/main/modules.d/45net-lib |
ifcfg is gone in dracut-ng 204. Looking at the module and its history, I'm pretty sure we don't actually use anything from the ifcfg module any more. anaconda-ifcfg.sh only uses save_netinfo, which is in net-lib. So let's turn the ifcfg dep into a net-lib dep instead. If I missed anything and we really are still relying on the ifcfg module then we need to fix that, since it's gone now. Related: rhbz#2343125 Resolves: RHEL-78746
M4rtinK
force-pushed
the
rhel-10-dracut-no-ifcfg
branch
from
e8d6761 to
7aa63cf
Compare
|
/kickstart-test --testtype smoke |
jstodola
approved these changes
Feb 12, 2025
M4rtinK
added
the
ready to merge
achilleas-k
added a commit
to achilleas-k/images
that referenced
this pull request
Feb 19, 2025
In RHEL 10 and Fedora 42, the ifcfg module was replaced by net-lib. Anaconda changes: - rhinstaller/anaconda#6125 - rhinstaller/anaconda#6155 Remove ifcfg from common anaconda dracut stage modules and add either ifcfg or net-lib to each installer based on distro version.
achilleas-k
added a commit
to achilleas-k/images
that referenced
this pull request
Feb 19, 2025
In RHEL 10 and Fedora 42, the ifcfg module was replaced by net-lib. Anaconda changes: - rhinstaller/anaconda#6125 - rhinstaller/anaconda#6155 Remove ifcfg from common anaconda dracut stage modules and add either ifcfg or net-lib to each installer based on distro version.
achilleas-k
added a commit
to achilleas-k/images
that referenced
this pull request
Feb 19, 2025
In RHEL 10 and Fedora 42, the ifcfg module was replaced by net-lib. Anaconda changes: - rhinstaller/anaconda#6125 - rhinstaller/anaconda#6155 Remove ifcfg from common anaconda dracut stage modules and add either ifcfg or net-lib to each installer based on distro version.
github-merge-queue bot
pushed a commit
to osbuild/images
that referenced
this pull request
Feb 20, 2025
In RHEL 10 and Fedora 42, the ifcfg module was replaced by net-lib. Anaconda changes: - rhinstaller/anaconda#6125 - rhinstaller/anaconda#6155 Remove ifcfg from common anaconda dracut stage modules and add either ifcfg or net-lib to each installer based on distro version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ifcfg is gone in dracut-ng 204. Looking at the module and its history, I'm pretty sure we don't actually use anything from the ifcfg module any more. anaconda-ifcfg.sh only uses save_netinfo, which is in net-lib. So let's turn the ifcfg dep into a net-lib dep instead.
If I missed anything and we really are still relying on the ifcfg module then we need to fix that, since it's gone now.
Related: rhbz#2343125
Resolves: RHEL-78746
RHEL 10 port of #6125
TODO