Shippeable v1 #52
Merged
Shippeable v1 #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Analytics - PR build notification The API returns `addons.search.enabled` and `addons.non_latest_version_warning` as `true` currently. So, we can decide to re-deploy the JS file enabling this features without doing an application deploy again. However, for now, we only want these pretty small addons to start testing the architecture and others.
agjohnson
approved these changes
Apr 17, 2023
|
How that would be? Do you have a documentation link I can read? 😅 |
|
Sure! I would use DefinePlugin: https://webpack.js.org/plugins/define-plugin/ There is a feature flag example there even, though we probably want to vary that value on whether the build was a development or production build, ie https://github.com/readthedocs/readthedocs-client/blob/main/webpack.config.js#L26 Anyways, not something that needs to hold this PR up, but would be an easy later change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API returns
addons.search.enabledandaddons.non_latest_version_warningastruecurrently. So, we can decide to re-deploy the JS file enabling this features without doing an application deploy again.However, for now, we only want these pretty small addons to start testing the architecture and others.
Related #26