Skip to content

Development: pattern to skip addons on production #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
humitos opened this issue Apr 18, 2023 · 0 comments · Fixed by #55
Closed

Development: pattern to skip addons on production #54

humitos opened this issue Apr 18, 2023 · 0 comments · Fixed by #55

Comments

@humitos
Copy link
Member

humitos commented Apr 18, 2023

We may want to have some addons installed while doing development, but not on production.

Take a look at #52 (comment)
humitos added a commit that referenced this issue Apr 19, 2023
@humitos
Packaging: define IS_PRODUCTION global variable
5078c91 
Use webpack's `DefinePlugin` to define `IS_PRODUCTION` global variable. This
variable is used to skip some features we are still working on and are not ready
for production yet.

We want them enabled in development (`npm run dev`) but skipped in
production (`npm run build`).

Closes #54
@humitos humitos mentioned this issue Apr 19, 2023
Merged
humitos added a commit that referenced this issue Apr 19, 2023
@humitos
Packaging: define IS_PRODUCTION global variable (#55)
6998852 
Use webpack's `DefinePlugin` to define `IS_PRODUCTION` global variable.
This variable is used to skip some features we are still working on and
are not ready for production yet.

We want them enabled in development (`npm run dev`) but skipped in
production (`npm run build`).

Closes #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Packaging: define IS_PRODUCTION global variable readthedocs/addons
1 participant
@humitos