Skip to content

Commit a5f88d0

Browse files
authored
Shippeable v1 (#52)
- Analytics - PR build notification The API returns `addons.search.enabled` and `addons.non_latest_version_warning` as `true` currently. So, we can decide to re-deploy the JS file enabling this features without doing an application deploy again. However, for now, we only want these pretty small addons to start testing the architecture and others. Related #26
1 parent f817046 commit a5f88d0

File tree

3 files changed

+21
-17
lines changed

3 files changed

+21
-17
lines changed

dist/readthedocs-client.js

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/index.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,10 @@ export function setup() {
1818
.then((config) => {
1919
let promises = [];
2020
const addons = [
21-
notification.NotificationAddon,
2221
analytics.AnalyticsAddon,
23-
search.SearchAddon,
22+
notification.NotificationAddon,
23+
// TODO: uncomment when we are ready to deploy
24+
// search.SearchAddon,
2425
];
2526

2627
for (const addon of addons) {

src/notification.js

+14-11
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,13 @@ export class NotificationElement extends LitElement {
5656
};
5757
}
5858

59-
if (
60-
config.addons.non_latest_version_warning.enabled &&
61-
!config.versions.current.external
62-
) {
63-
this.calculateHighestVersion();
64-
}
59+
// TODO: uncomment when ready to deploy non-latest version warning
60+
// if (
61+
// config.addons.non_latest_version_warning.enabled &&
62+
// !config.versions.current.external
63+
// ) {
64+
// this.calculateHighestVersion();
65+
// }
6566
}
6667

6768
render() {
@@ -75,12 +76,14 @@ export class NotificationElement extends LitElement {
7576
if (this.config.addons.external_version_warning.enabled) {
7677
return this.renderExternalVersionWarning();
7778
}
78-
} else if (
79-
this.config.addons.non_latest_version_warning.enabled &&
80-
this.highest_version
81-
) {
82-
return this.renderNonLatestVersionWarning();
8379
}
80+
// TODO: uncomment when ready to deploy non-latest version warning
81+
// else if (
82+
// this.config.addons.non_latest_version_warning.enabled &&
83+
// this.highest_version
84+
// ) {
85+
// return this.renderNonLatestVersionWarning();
86+
// }
8487
return nothing;
8588
}
8689

0 commit comments

Comments
 (0)