Install pre-compiled files into source tree #242
Conversation
|
Looks like there are merge conflicts (which are probably what's also causing the CI failure?) |
|
That CI failure is why I'm thinking this change doesn't want to have the check action, as the only change has been in the SDK so we don't really need to update the The conflict is just because the code for those files has been updated |
Keep the step name "Install dependencies (Linux)" in case dependencies change later, to make changing all of them simpler
will-v-pi
force-pushed
the
install-compiled
branch
from
d797810 to
1465edf
Compare
will-v-pi
force-pushed
the
install-compiled
branch
from
8552532 to
a4789e0
Compare
will-v-pi
force-pushed
the
install-compiled
branch
from
a4789e0 to
52aec5a
Compare
will-v-pi
force-pushed
the
install-compiled
branch
from
2a7362b to
1c1c67a
Compare
Simplify CMakeLists.txt and BUILD.bazel skips Install all ELFs as files, so they aren't marked as executable
|
Hmmm, something that's just occurred to me: if a change was made to a comment in one of the |
Yeah, that's something to bear in mind, but I think that should be fine |
CMakeLists.txt
Outdated
| if (USE_PRECOMPILED) | ||
| set(EXTERNAL_PROJECT_INSTALL_COMMAND "") | ||
| else() | ||
| set(EXTERNAL_PROJECT_INSTALL_COMMAND ${CMAKE_COMMAND} --install .) |
There was a problem hiding this comment.
"," gives me the willies
There was a problem hiding this comment.
I've removed that and added a better fix, with a new CMake function to handle the install vs don't install cases
This fixes the BUILD_ALWAYS issues as it's now only set when `USE_PRECOMPILED=false`, and also removes the need for `${CMAKE_COMMAND} --install .`
It's needed so if you update the binaries (eg `git pull`) they get re-copied and re-installed
This adds an install step in the external projects when
USE_PRECOMPILED=falseto copy the compiled binaries into the source tree.This also adds a new action to check that the pre-compiled files have been updated correctly, although I'm not sure if we should add that or not, as the files will change slightly depending on the compiler/SDK used so that action will probably fail quite a lot?
Fixes #240 (comment)