Change workflow to just check for file updates, rather than identical files

Author: will-v-pi

.github/workflows/check_precompiled.yml

@@ -1,8 +1,11 @@
 name: Check Precompiled Binaries
 
 on:
-  push:
   pull_request:
+    paths:
+      - 'enc_bootloader/**'
+      - 'picoboot_flash_id/**'
+      - 'xip_ram_perms/**'
 
 jobs:
   check-precompiled:
@@ -23,50 +26,65 @@ jobs:
           path: pico-sdk
           submodules: 'true'
 
-      - name: Create copies of the precompiled binaries
-        run: |
-          cp enc_bootloader/enc_bootloader.elf enc_bootloader/enc_bootloader.elf.orig
-          cp enc_bootloader/enc_bootloader_mbedtls.elf enc_bootloader/enc_bootloader_mbedtls.elf.orig
-          cp picoboot_flash_id/flash_id.bin picoboot_flash_id/flash_id.bin.orig
-          cp xip_ram_perms/xip_ram_perms.elf xip_ram_perms/xip_ram_perms.elf.orig
-
       - name: Build and Install
         run: |
           cmake -S . -B build -G "Ninja" -D PICO_SDK_PATH="${{ github.workspace }}/pico-sdk" -D USE_PRECOMPILED=FALSE
           cmake --build build
           sudo cmake --install build
 
-      - name: Check if precompiled binaries are up to date
-        env:
-          ALL_FINE: 1
+      - name: Check precompiled binaries have been updated
         run: |
-          # Compare the files
-          if ! cmp -s enc_bootloader/enc_bootloader.elf enc_bootloader/enc_bootloader.elf.orig; then
-            echo "Error: enc_bootloader.elf is out of date"
-            ALL_FINE=0
-          fi
+          updated_files=$(curl -s -u "${{ github.repository_owner }}":"${{ github.token }}" -H "Accept: application/vnd.github.v3+json" "${{ github.event.pull_request._links.self.href }}/files")
+          updated_files=$(jq -r '.[] | .filename' <<<"$updated_files")
 
-          if ! cmp -s enc_bootloader/enc_bootloader_mbedtls.elf enc_bootloader/enc_bootloader_mbedtls.elf.orig; then
-            echo "Error: enc_bootloader_mbedtls.elf is out of date"
-            ALL_FINE=0
-          fi
+          echo "Updated files: $updated_files"
 
-          if ! cmp -s picoboot_flash_id/flash_id.bin picoboot_flash_id/flash_id.bin.orig; then
-            echo "Error: flash_id.bin is out of date"
-            ALL_FINE=0
-          fi
+          # enc_bootloader
+          enc_bootloader_elf_not_updated=$(! echo "$updated_files" | grep -q "enc_bootloader/enc_bootloader.elf")
+          enc_bootloader_mbedtls_elf_not_updated=$(! echo "$updated_files" | grep -q "enc_bootloader/enc_bootloader_mbedtls.elf")
+          echo "enc_bootloader_elf_not_updated: $enc_bootloader_elf_not_updated"
+          echo "enc_bootloader_mbedtls_elf_not_updated: $enc_bootloader_mbedtls_elf_not_updated"
+          for file in enc_bootloader/*; do
+            if echo "$updated_files" | grep -q "$file"; then
+              echo "File $file is in the PR"
+              if $enc_bootloader_elf_not_updated || $enc_bootloader_mbedtls_elf_not_updated; then
+                echo "File $file is in the PR but not enc_bootloader/enc_bootloader.elf"
+                exit 1
+              fi
+            else
+              echo "File $file is not in the PR"
+            fi
+          done
 
-          if ! cmp -s xip_ram_perms/xip_ram_perms.elf xip_ram_perms/xip_ram_perms.elf.orig; then
-            echo "Error: xip_ram_perms.elf is out of date"
-            ALL_FINE=0
-          fi
+          # picoboot_flash_id
+          flash_id_bin_not_updated=$(! echo "$updated_files" | grep -q "picoboot_flash_id/flash_id.bin")
+          echo "flash_id_bin_not_updated: $flash_id_bin_not_updated"
+          for file in picoboot_flash_id/*; do
+            if echo "$updated_files" | grep -q "$file"; then
+              echo "File $file is in the PR"
+              if $flash_id_bin_not_updated; then
+                echo "File $file is in the PR but not picoboot_flash_id/flash_id.bin"
+                exit 1
+              fi
+            else
+              echo "File $file is not in the PR"
+            fi
+          done
 
-          if [ "$ALL_FINE" -eq 1 ]; then
-            echo "All precompiled binaries are up to date"
-          else
-            echo "Some precompiled binaries are out of date - update by building with USE_PRECOMPILED=FALSE, or use the artifact from this workflow"
-            exit 1
-          fi
+          # xip_ram_perms
+          xip_ram_perms_elf_not_updated=$(! echo "$updated_files" | grep -q "xip_ram_perms/xip_ram_perms.elf")
+          echo "xip_ram_perms_elf_not_updated: $xip_ram_perms_elf_not_updated"
+          for file in xip_ram_perms/*; do
+            if echo "$updated_files" | grep -q "$file"; then
+              echo "File $file is in the PR"
+              if $xip_ram_perms_elf_not_updated; then
+                echo "File $file is in the PR but not xip_ram_perms/xip_ram_perms.elf"
+                exit 1
+              fi
+            else
+              echo "File $file is not in the PR"
+            fi
+          done
 
       - name: Upload new precompiled binaries
         if: always()