Change workflow to just check for file updates, rather than identical files

Author: will-v-pi

.github/workflows/check_precompiled.yml

@@ -1,12 +1,14 @@
 name: Check Precompiled Binaries
 
 on:
-  push:
   pull_request:
+    paths:
+      - 'enc_bootloader/**'
+      - 'picoboot_flash_id/**'
+      - 'xip_ram_perms/**'
 
 jobs:
   check-precompiled:
-    if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
@@ -23,49 +25,65 @@ jobs:
           path: pico-sdk
           submodules: 'true'
 
-      - name: Create copies of the precompiled binaries
-        run: |
-          cp enc_bootloader/enc_bootloader.elf enc_bootloader/enc_bootloader.elf.orig
-          cp enc_bootloader/enc_bootloader_mbedtls.elf enc_bootloader/enc_bootloader_mbedtls.elf.orig
-          cp picoboot_flash_id/flash_id.bin picoboot_flash_id/flash_id.bin.orig
-          cp xip_ram_perms/xip_ram_perms.elf xip_ram_perms/xip_ram_perms.elf.orig
-
       - name: Build and Install
         run: |
           cmake -S . -B build -G "Ninja" -D PICO_SDK_PATH="${{ github.workspace }}/pico-sdk" -D USE_PRECOMPILED=FALSE
           cmake --build build
           sudo cmake --install build
 
-      - name: Check if precompiled binaries are up to date
-        env:
-          ALL_FINE: 1
+      - name: Check precompiled binaries have been updated
         run: |
-          # Compare the files
-          if ! cmp -s enc_bootloader/enc_bootloader.elf enc_bootloader/enc_bootloader.elf.orig; then
-            echo "Error: enc_bootloader.elf is out of date"
-            ALL_FINE=0
-          fi
+          updated_files=$(curl -s -u "${{ github.repository_owner }}":"${{ github.token }}" -H "Accept: application/vnd.github.v3+json" "${{ github.event.pull_request._links.self.href }}/files")
+          updated_files=$(jq -r '.[] | .filename' <<<"$updated_files")
 
-          if ! cmp -s enc_bootloader/enc_bootloader_mbedtls.elf enc_bootloader/enc_bootloader_mbedtls.elf.orig; then
-            echo "Error: enc_bootloader_mbedtls.elf is out of date"
-            ALL_FINE=0
-          fi
+          echo "Updated files: $updated_files"
 
-          if ! cmp -s picoboot_flash_id/flash_id.bin picoboot_flash_id/flash_id.bin.orig; then
-            echo "Error: flash_id.bin is out of date"
-            ALL_FINE=0
+          # enc_bootloader
+          echo "$updated_files" | grep -q "enc_bootloader/.*\.elf"
+          enc_bootloader_elf_not_updated=$?
+          if [ $enc_bootloader_elf_not_updated -eq 1 ]; then
+              echo "Checking enc_bootloader files for modifications as ELFs have not been updated"
+              for file in enc_bootloader/*; do
+                  if echo "$file" | grep -q "CMakeLists.txt" || echo "$file" | grep -q "BUILD.bazel"; then
+                      continue
+                  fi
+                  if echo "$updated_files" | grep -q "$file"; then
+                      echo "File $file is in the PR but enc_bootloader ELFs have not been updated"
+                      exit 1
+                  fi
+              done
           fi
 
-          if ! cmp -s xip_ram_perms/xip_ram_perms.elf xip_ram_perms/xip_ram_perms.elf.orig; then
-            echo "Error: xip_ram_perms.elf is out of date"
-            ALL_FINE=0
+          # picoboot_flash_id
+          echo "$updated_files" | grep -q "picoboot_flash_id/.*\.bin"
+          flash_id_bin_not_updated=$?
+          if [ $flash_id_bin_not_updated -eq 1 ]; then
+              echo "Checking picoboot_flash_id files for modifications as BINs have not been updated"
+              for file in picoboot_flash_id/*; do
+                  if echo "$file" | grep -q "CMakeLists.txt" || echo "$file" | grep -q "BUILD.bazel"; then
+                      continue
+                  fi
+                  if echo "$updated_files" | grep -q "$file"; then
+                      echo "File $file is in the PR but flash_id BINs have not been updated"
+                      exit 1
+                  fi
+              done
           fi
 
-          if [ "$ALL_FINE" -eq 1 ]; then
-            echo "All precompiled binaries are up to date"
-          else
-            echo "Some precompiled binaries are out of date - update by building with USE_PRECOMPILED=FALSE, or use the artifact from this workflow"
-            exit 1
+          # xip_ram_perms
+          echo "$updated_files" | grep -q "xip_ram_perms/.*\.elf"
+          xip_ram_perms_elf_not_updated=$?
+          if [ $xip_ram_perms_elf_not_updated -eq 1 ]; then
+              echo "Checking xip_ram_perms files for modifications as ELFs have not been updated"
+              for file in xip_ram_perms/*; do
+                  if echo "$file" | grep -q "CMakeLists.txt" || echo "$file" | grep -q "BUILD.bazel"; then
+                      continue
+                  fi
+                  if echo "$updated_files" | grep -q "$file"; then
+                      echo "File $file is in the PR but xip_ram_perms ELFs have not been updated"
+                      exit 1
+                  fi
+              done
           fi
 
       - name: Upload new precompiled binaries