Schema Analyzer to infer component schemas from classes #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhailshilkov
force-pushed
the
mikhailshilkov/schema-analyzer
branch
from
0842767 to
2ab10a8
Compare
Frassle
reviewed
Feb 21, 2025
This is mostly a utility class, it will be used in a provider implementation similar to this Java one |
tgummerer
approved these changes
Feb 24, 2025
| /// <returns>A PackageSpec containing the complete schema for all components and their types</returns> | ||
| public static PackageSpec GenerateSchema(Metadata metadata, params Type[] componentTypes) | ||
| { | ||
| if (metadata?.Name == null || string.IsNullOrWhiteSpace(metadata.Name)) |
There was a problem hiding this comment.
Should we evaulate this against the same regex we have in pulumi.json?
Also micronit, I'd prefer curly braces in all if statements even if they are just one line. Not sure we have a linter or guidelines for that though.
mikhailshilkov
force-pushed
the
mikhailshilkov/schema-analyzer
branch
from
8595302 to
5e0ca99
Compare
mikhailshilkov
force-pushed
the
mikhailshilkov/schema-analyzer
branch
from
5e0ca99 to
b08bc13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
ComponentAnalyzer.GenerateSchemawhich takes either an assembly or a list of component resources and produces a serializable package schema structure. Infers component resources and their dependent types. Here are the features that this PR implements and tests:Resolve #468 (we'll track missing features in separate issues)