Improve package name validation

Author: mikhailshilkov

sdk/Pulumi.Tests/Provider/ComponentAnalyzerTests.cs

@@ -851,6 +851,35 @@ public void TestAnalyzeRequiredOptionalProperties()
         AssertSchemaEqual(expected, schema);
     }
 
+    [Theory]
+    [InlineData("123test", "Package name must start with a letter and contain only letters, numbers, hyphens, and underscores")]
+    [InlineData("test!", "Package name must start with a letter and contain only letters, numbers, hyphens, and underscores")]
+    [InlineData("test space", "Package name must start with a letter and contain only letters, numbers, hyphens, and underscores")]
+    [InlineData("", "Package name cannot be empty or whitespace")]
+    [InlineData(" ", "Package name cannot be empty or whitespace")]
+    [InlineData(null, "Package name cannot be empty or whitespace")]
+    public void TestInvalidPackageNames(string? name, string expectedError)
+    {
+        var metadata = new Metadata(name!);
+        var exception = Assert.Throws<ArgumentException>(() =>
+            ComponentAnalyzer.GenerateSchema(metadata, typeof(SelfSignedCertificate)));
+
+        Assert.Equal($"{expectedError} (Parameter 'metadata')", exception.Message);
+    }
+
+    [Theory]
+    [InlineData("test")]
+    [InlineData("test-package")]
+    [InlineData("test_package")]
+    [InlineData("test123")]
+    [InlineData("myPackage")]
+    public void TestValidPackageNames(string name)
+    {
+        var metadata = new Metadata(name);
+        var schema = ComponentAnalyzer.GenerateSchema(metadata, typeof(SelfSignedCertificate));
+        Assert.Equal(name, schema.Name);
+    }
+
     private readonly Metadata _metadata = new Metadata("my-component", "0.0.1", "Test package");
 
     private static PackageSpec CreateBasePackageSpec(

sdk/Pulumi/Provider/ComponentAnalyzer.cs

@@ -5,6 +5,7 @@
 using System.Collections.Immutable;
 using System.Linq;
 using System.Reflection;
+using System.Text.RegularExpressions;
 namespace Pulumi.Experimental.Provider
 {
     /// <summary>
@@ -42,7 +43,16 @@ public static PackageSpec GenerateSchema(Metadata metadata, Assembly assembly)
         public static PackageSpec GenerateSchema(Metadata metadata, params Type[] componentTypes)
         {
             if (metadata?.Name == null || string.IsNullOrWhiteSpace(metadata.Name))
+            {
                 throw new ArgumentException("Package name cannot be empty or whitespace", nameof(metadata));
+            }
+
+            if (!Regex.IsMatch(metadata.Name, "^[a-zA-Z][-a-zA-Z0-9_]*$"))
+            {
+                throw new ArgumentException(
+                    "Package name must start with a letter and contain only letters, numbers, hyphens, and underscores", 
+                    nameof(metadata));
+            }
 
             if (componentTypes.Length == 0)
             {